Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11848

Incorrect arguments to sizeof in DomainSocket.c

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: native
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Length of buffer to be zeroed using sizeof , should not use the address of the structure rather the structure itself.

      DomainSocket.c line 156

      Replace current:
      memset(&addr,0,sizeof,(&addr));

      With:
      memset(&addr, 0, sizeof(addr));

      1. HADOOP-11848.001.patch
        0.7 kB
        Malcolm Kavalsky

        Activity

        Hide
        cmccabe Colin P. McCabe added a comment -

        I agree, this was not what was intended. Malcolm, do you want to post a patch for this?

        Show
        cmccabe Colin P. McCabe added a comment - I agree, this was not what was intended. Malcolm, do you want to post a patch for this?
        Hide
        malcolm kavalsky Malcolm Kavalsky added a comment -

        I wanted to send in a patch for this yesterday, but am having trouble
        with git :

        $ git remote update
        Fetching origin
        fatal: read error: Connection reset by peer
        error: Could not fetch origin

        So, perhaps you could patch this ?

        Show
        malcolm kavalsky Malcolm Kavalsky added a comment - I wanted to send in a patch for this yesterday, but am having trouble with git : $ git remote update Fetching origin fatal: read error: Connection reset by peer error: Could not fetch origin So, perhaps you could patch this ?
        Hide
        cnauroth Chris Nauroth added a comment -

        Hi Malcolm Kavalsky. Is your remote git://git.apache.org/hadoop-common.git? If so, then I noticed the same thing earlier today. We probably need to follow up on that with Apache Infrastructure.

        Meanwhile though, I think you can make progress by using a different remote: https://git-wip-us.apache.org/repos/asf/hadoop.git. This is the remote where we actually push committed patches. git.apache.org is a mirror of that, and then the github copy is a mirror of git.apache.org.

        Show
        cnauroth Chris Nauroth added a comment - Hi Malcolm Kavalsky . Is your remote git://git.apache.org/hadoop-common.git? If so, then I noticed the same thing earlier today. We probably need to follow up on that with Apache Infrastructure. Meanwhile though, I think you can make progress by using a different remote: https://git-wip-us.apache.org/repos/asf/hadoop.git . This is the remote where we actually push committed patches. git.apache.org is a mirror of that, and then the github copy is a mirror of git.apache.org.
        Hide
        malcolm kavalsky Malcolm Kavalsky added a comment -

        Patch attached

        Show
        malcolm kavalsky Malcolm Kavalsky added a comment - Patch attached
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 43s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 common tests 21m 43s Tests passed in hadoop-common.
            37m 31s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12727147/HADOOP-11848.001.patch
        Optional Tests javac unit
        git revision trunk / 6f8003d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6145/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6145/testReport/
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6145//console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 common tests 21m 43s Tests passed in hadoop-common.     37m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727147/HADOOP-11848.001.patch Optional Tests javac unit git revision trunk / 6f8003d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6145/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6145/testReport/ Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6145//console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1

        Show
        cmccabe Colin P. McCabe added a comment - +1
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7639 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7639/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7639 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7639/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2104 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2104/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2104 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2104/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/163/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/163/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/172/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/172/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #906 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/906/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #906 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/906/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/173/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/173/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2122 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2122/)
        HADOOP-11848. Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2122 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2122/ ) HADOOP-11848 . Incorrect arguments to sizeof in DomainSocket.c (Malcolm Kavalsky via Colin P. McCabe) (cmccabe: rev a3b1d8c90288a6237089a98d4a81c25f44aedb2c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c

          People

          • Assignee:
            malcolm kavalsky Malcolm Kavalsky
            Reporter:
            malcolm kavalsky Malcolm Kavalsky
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development