Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11812

Implement listLocatedStatus for ViewFileSystem to speed up split calculation

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      ViewFileSystem is currently not taking advantage of MAPREDUCE-1981. This causes several x of RPC overhead and added latency.

      1. HADOOP-11812.001.patch
        21 kB
        Gera Shegalov
      2. HADOOP-11812.002.patch
        20 kB
        Gera Shegalov
      3. HADOOP-11812.003.patch
        20 kB
        Gera Shegalov
      4. HADOOP-11812.004.patch
        20 kB
        Gera Shegalov
      5. HADOOP-11812.005.patch
        23 kB
        Gera Shegalov

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723872/HADOOP-11812.001.patch
          against trunk revision dd852f5.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.fs.viewfs.TestViewfsFileStatus

          The following test timeouts occurred in hadoop-common-project/hadoop-common:

          org.apache.hadoop.util.TestMachineList

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6075//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/6075//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6075//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723872/HADOOP-11812.001.patch against trunk revision dd852f5. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.viewfs.TestViewfsFileStatus The following test timeouts occurred in hadoop-common-project/hadoop-common: org.apache.hadoop.util.TestMachineList Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6075//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/6075//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6075//console This message is automatically generated.
          Hide
          jira.shegalov Gera Shegalov added a comment -

          002 to fix the bug caught by TestViewfsStatus

          Show
          jira.shegalov Gera Shegalov added a comment - 002 to fix the bug caught by TestViewfsStatus
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724032/HADOOP-11812.002.patch
          against trunk revision 265ed1f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6078//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/6078//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6078//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724032/HADOOP-11812.002.patch against trunk revision 265ed1f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6078//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/6078//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6078//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724028/HADOOP-11812.002.patch
          against trunk revision 265ed1f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

          org.apache.hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6077//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6077//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724028/HADOOP-11812.002.patch against trunk revision 265ed1f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6077//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6077//console This message is automatically generated.
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Test failure is unrelated. I will update the patch to satisfy FindBugs but path-based equality defined in FileStatus is actually sufficient.

          Show
          jira.shegalov Gera Shegalov added a comment - Test failure is unrelated. I will update the patch to satisfy FindBugs but path-based equality defined in FileStatus is actually sufficient.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724096/HADOOP-11812.003.patch
          against trunk revision dc0282d.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6083//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6083//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724096/HADOOP-11812.003.patch against trunk revision dc0282d. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6083//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6083//console This message is automatically generated.
          Hide
          laurentgo Laurent Goujon added a comment -

          You can probably make fixFileStatus a generic method <T extends FileStatus> fixFileStatus(T orig, Path qualified) and avoid casting

          Show
          laurentgo Laurent Goujon added a comment - You can probably make fixFileStatus a generic method <T extends FileStatus> fixFileStatus(T orig, Path qualified) and avoid casting
          Hide
          cnauroth Chris Nauroth added a comment -

          Hi Gera Shegalov. Nice find, and thank you for providing a patch. It looks great overall.

          One possible gap is that it seems there is nothing in the tests that actually checks listLocatedStatus has been overridden and is returning meaningful locations from the underlying mounts. ViewFileSystemBaseTest#listStatusInternal optionally queries for LocatedFileStatus instances, but those still could have come from the base FileSystem implementation. I tried reverting all of the main code and leaving just the test code changes, and all of the tests still passed. Ideally we'd have a test that could catch regressions by failing if this code ever got removed by mistake.

          One way to do this might be to add tests in TestChRootedFileSystem and TestViewFileSystemDelegation. These tests are designed to run operations against a ChRootedFileSystem/ViewFileSystem and then verify mocks to confirm that the calls actually got delegated to the underlying mounts. What are your thoughts?

          Show
          cnauroth Chris Nauroth added a comment - Hi Gera Shegalov . Nice find, and thank you for providing a patch. It looks great overall. One possible gap is that it seems there is nothing in the tests that actually checks listLocatedStatus has been overridden and is returning meaningful locations from the underlying mounts. ViewFileSystemBaseTest#listStatusInternal optionally queries for LocatedFileStatus instances, but those still could have come from the base FileSystem implementation. I tried reverting all of the main code and leaving just the test code changes, and all of the tests still passed. Ideally we'd have a test that could catch regressions by failing if this code ever got removed by mistake. One way to do this might be to add tests in TestChRootedFileSystem and TestViewFileSystemDelegation . These tests are designed to run operations against a ChRootedFileSystem / ViewFileSystem and then verify mocks to confirm that the calls actually got delegated to the underlying mounts. What are your thoughts?
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Thanks for reviewing Laurent Goujon. 004 attached.

          Show
          jira.shegalov Gera Shegalov added a comment - Thanks for reviewing Laurent Goujon . 004 attached.
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Hi Chris Nauroth, thanks for looking into the patch. I have verified the patch to get rid of getFileBlockLocations on our production cluster. However, I agree a unit test to check that the non-default listLocatedFileStatus is called makes sense.

          Show
          jira.shegalov Gera Shegalov added a comment - Hi Chris Nauroth , thanks for looking into the patch. I have verified the patch to get rid of getFileBlockLocations on our production cluster. However, I agree a unit test to check that the non-default listLocatedFileStatus is called makes sense.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724674/HADOOP-11812.004.patch
          against trunk revision 2cc9514.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The applied patch generated 1149 javac compiler warnings (more than the trunk's current 1148 warnings).

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6094//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/6094//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6094//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724674/HADOOP-11812.004.patch against trunk revision 2cc9514. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1149 javac compiler warnings (more than the trunk's current 1148 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6094//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/6094//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6094//console This message is automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          Thank you, Gera. I'll be +1 after addition of that unit test and fixing the javac warning found in the last Jenkins run.

          Show
          cnauroth Chris Nauroth added a comment - Thank you, Gera. I'll be +1 after addition of that unit test and fixing the javac warning found in the last Jenkins run.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726530/HADOOP-11812.005.patch
          against trunk revision 5c97db0.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6127//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6127//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726530/HADOOP-11812.005.patch against trunk revision 5c97db0. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6127//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6127//console This message is automatically generated.
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Chris Nauroth, please take a look at 005 version with a test.

          Show
          jira.shegalov Gera Shegalov added a comment - Chris Nauroth , please take a look at 005 version with a test.
          Hide
          cnauroth Chris Nauroth added a comment -

          Gera Shegalov, thanks for adding the new test in v005. It looks good. However, comparing to v004, it also looks like Laurent's earlier feedback on the fixFileStatus method got dropped. Was that intentional?

          Show
          cnauroth Chris Nauroth added a comment - Gera Shegalov , thanks for adding the new test in v005. It looks good. However, comparing to v004, it also looks like Laurent's earlier feedback on the fixFileStatus method got dropped. Was that intentional?
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Chris Nauroth, yes, unfortunately I had to undo Laurent Goujon's suggestion because it required that unchecked cast. The method does not quite do what is expected by this pattern for the "file" case: in-class is the same as out-class. In the end, I was basically choosing between two alternatives: the one from 003 and the one from 004. They both required just one cast, but 004's is unchecked with a new warning.

          Show
          jira.shegalov Gera Shegalov added a comment - Chris Nauroth , yes, unfortunately I had to undo Laurent Goujon 's suggestion because it required that unchecked cast. The method does not quite do what is expected by this pattern for the "file" case: in-class is the same as out-class. In the end, I was basically choosing between two alternatives: the one from 003 and the one from 004. They both required just one cast, but 004's is unchecked with a new warning.
          Hide
          cnauroth Chris Nauroth added a comment -

          Thanks, that makes sense now. I missed the javac warning from the v004 Jenkins run.

          I am +1 for v005 pending a Jenkins run on that version.

          Show
          cnauroth Chris Nauroth added a comment - Thanks, that makes sense now. I missed the javac warning from the v004 Jenkins run. I am +1 for v005 pending a Jenkins run on that version.
          Show
          jira.shegalov Gera Shegalov added a comment - Chris, Jenkins run with 005 is the last Hadoop QA comment, and it is green: https://issues.apache.org/jira/browse/HADOOP-11812?focusedCommentId=14502526&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14502526
          Hide
          cnauroth Chris Nauroth added a comment -

          Gera, once again you are correct, so here is my unconditional +1.

          Show
          cnauroth Chris Nauroth added a comment - Gera, once again you are correct, so here is my unconditional +1.
          Hide
          jira.shegalov Gera Shegalov added a comment -

          Thanks Laurent Goujon and Chris Nauroth for review! Committed to trunk and branch-2.

          Show
          jira.shegalov Gera Shegalov added a comment - Thanks Laurent Goujon and Chris Nauroth for review! Committed to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #7628 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7628/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #7628 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7628/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2103 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2103/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2103 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2103/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #162 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/162/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #162 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/162/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/171/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/171/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #905 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/905/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #905 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/905/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/172/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/172/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2121 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2121/)
          HADOOP-11812. Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2121 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2121/ ) HADOOP-11812 . Implement listLocatedStatus for ViewFileSystem to speed up split calculation (gera) (gera: rev 6d2cf9fbbd02482315a091ab07af26e40cc5134f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFsLocatedFileStatus.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocatedFileStatus.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.6.1 after Akira Ajisaka verified that the patch applies cleanly.

          Ran compilation and TestChRootedFileSystem, TestViewFileSystemLocalFileSystem, TestViewFileSystemWithAuthorityLocalFileSystem, TestViewFileSystemAtHdfsRoot, TestViewFileSystemHdfs before the push.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1 after Akira Ajisaka verified that the patch applies cleanly. Ran compilation and TestChRootedFileSystem, TestViewFileSystemLocalFileSystem, TestViewFileSystemWithAuthorityLocalFileSystem, TestViewFileSystemAtHdfsRoot, TestViewFileSystemHdfs before the push.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1.

          branch-2 patch applies cleanly. Ran compilation and TestChRootedFileSystem, TestViewFileSystemLocalFileSystem, TestViewFileSystemAtHdfsRoot, TestViewFileSystemHdfs before the push.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1. branch-2 patch applies cleanly. Ran compilation and TestChRootedFileSystem, TestViewFileSystemLocalFileSystem, TestViewFileSystemAtHdfsRoot, TestViewFileSystemHdfs before the push.

            People

            • Assignee:
              jira.shegalov Gera Shegalov
              Reporter:
              jira.shegalov Gera Shegalov
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development