Hadoop Common
  1. Hadoop Common
  2. HADOOP-1180

NNbench test should be able to test the checksumfilesystem as well as the raw filesystem

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The NNbench test should have the option of testing a file system with checksums turned on and with checksums turned off. The original behaviour of nnbench test was to test hdfs without checksums.

      1. nnbench.patch
        4 kB
        dhruba borthakur

        Activity

        Hide
        dhruba borthakur added a comment -

        We will continue to run NNbench with the checksum file system.

        Show
        dhruba borthakur added a comment - We will continue to run NNbench with the checksum file system.
        Hide
        Doug Cutting added a comment -

        -1 This patch may be rendered obsolete by HADOOP-1134. And, the way it is written, the 'useChecksum=false' mode will silently fail to work once HADOOP-1134 is completed. So, if we feel we'll want to continue to support this feature after HADOOP-1134, then we should add an explicit way of constructing an HDFS FileSystem that does not perform checksumming, rather than relying on 'instanceof ChecksumFileSystem'.

        Show
        Doug Cutting added a comment - -1 This patch may be rendered obsolete by HADOOP-1134 . And, the way it is written, the 'useChecksum=false' mode will silently fail to work once HADOOP-1134 is completed. So, if we feel we'll want to continue to support this feature after HADOOP-1134 , then we should add an explicit way of constructing an HDFS FileSystem that does not perform checksumming, rather than relying on 'instanceof ChecksumFileSystem'.
        Hide
        Nigel Daley added a comment -

        +1 code review

        This is just a test fix.

        Show
        Nigel Daley added a comment - +1 code review This is just a test fix.
        Show
        Hadoop QA added a comment - +1, because http://issues.apache.org/jira/secure/attachment/12354470/nnbench.patch applied and successfully tested against trunk revision http://svn.apache.org/repos/asf/lucene/hadoop/trunk/523072 . Results are at http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch
        Hide
        dhruba borthakur added a comment -

        The default behaviour of the nnbench benchmark is to measure a file system without checksum. If the "-useChecksum" option is specified, then it measures performance with checksums switched on.

        Show
        dhruba borthakur added a comment - The default behaviour of the nnbench benchmark is to measure a file system without checksum. If the "-useChecksum" option is specified, then it measures performance with checksums switched on.

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development