Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11692

Improve authentication failure WARN message to avoid user confusion

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Lots of the following messages appeared in NN log:

      2014-12-10 12:18:15,728 WARN SecurityLogger.org.apache.hadoop.ipc.Server: Auth failed for <ipAddress>:39838:null (DIGEST-MD5: IO error acquiring password)
      2014-12-10 12:18:15,728 INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: readAndProcess from client <ipAddress> threw exception [org.apache.hadoop.ipc.StandbyException: Operation category READ is not supported in state standby]
      ......
      SecurityLogger.org.apache.hadoop.ipc.Server: Auth failed for <ipAddress>:39843:null (DIGEST-MD5: IO error acquiring password)
      2014-12-10 12:18:15,790 INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: readAndProcess from client <ipAddress> threw exception [org.apache.hadoop.ipc.StandbyException: Operation category READ is not supported in state standby]

      The real reason of failure is the second message about StandbyException,
      However, the first message is confusing because it talks about "DIGEST-MD5: IO error acquiring password".

      Filing this jira to modify the first message to have more comprehensive information that can be obtained from getCauseForInvalidToken(e).

             try {
                saslResponse = processSaslMessage(saslMessage);
              } catch (IOException e) {
                rpcMetrics.incrAuthenticationFailures();
                // attempting user could be null
                AUDITLOG.warn(AUTH_FAILED_FOR + this.toString() + ":"
                    + attemptingUser + " (" + e.getLocalizedMessage() + ")");
                throw (IOException) getCauseForInvalidToken(e);
              }
      

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7331 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7331/)
          HADOOP-11692. Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7331 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7331/ ) HADOOP-11692 . Amendment to CHANGES.txt. (yzhang: rev 03b77ede9249d7d16654257035dfc01a7a0a8c50) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2078 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2078/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2078 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2078/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/128/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/128/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/119/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/119/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2060 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2060/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2060 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2060/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #862 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/862/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #862 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/862/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/128/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/128/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          yzhangal Yongjun Zhang added a comment -

          Found that the diff between trunk and branch-2 is because HADOOP-10044 is in trunk but not branch-2.

          Show
          yzhangal Yongjun Zhang added a comment - Found that the diff between trunk and branch-2 is because HADOOP-10044 is in trunk but not branch-2.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks again Jing, I committed to trunk and branch-2.

          I noticed that there is some diff between trunk and branch-2 in Server.java. That is, getTrueCause() is in trunk and getCauseForInvalidToken is in branch-2. Will look a bit more to find out why.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks again Jing, I committed to trunk and branch-2. I noticed that there is some diff between trunk and branch-2 in Server.java. That is, getTrueCause() is in trunk and getCauseForInvalidToken is in branch-2. Will look a bit more to find out why.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7289 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7289/)
          HADOOP-11692. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7289 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7289/ ) HADOOP-11692 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev de1101cb5be2d8efd0ef4945f64ccfe7cbd01049) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703135/HDFS-7857.001.patch
          against trunk revision 5578e22.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ipc.TestRPCWaitForProxy

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5888//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5888//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703135/HDFS-7857.001.patch against trunk revision 5578e22. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ipc.TestRPCWaitForProxy Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5888//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5888//console This message is automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2077 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2077/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
            Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2077 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2077/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/127/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
            Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/127/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/118/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
            Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/118/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2059 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2059/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
            Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2059 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2059/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #861 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/861/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
            Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #861 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/861/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #127 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/127/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
            Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #127 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/127/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7286 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7286/)
          Revert "HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7286 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7286/ ) Revert " HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang." (yzhang: rev 5578e22ce9ca6cceb510c22ec307b1869ce1a7c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks a lot Jing Zhao!

          I tried to commit and then I realize that I had to do two things: 1, make this jira HADOOP instead of HDFS, 2, I forgot to modify the CHANGES.txt file. So I reverted the commit. My bad.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks a lot Jing Zhao ! I tried to commit and then I realize that I had to do two things: 1, make this jira HADOOP instead of HDFS, 2, I forgot to modify the CHANGES.txt file. So I reverted the commit. My bad.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7285 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7285/)
          HDFS-7857. Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7285 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7285/ ) HDFS-7857 . Improve authentication failure WARN message to avoid user confusion. Contributed by Yongjun Zhang. (yzhang: rev d799fbe1ccf8752c44f087e34b5f400591d3b5bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          jingzhao Jing Zhao added a comment -

          +1. Thanks for the improvement, Yongjun Zhang!

          Show
          jingzhao Jing Zhao added a comment - +1. Thanks for the improvement, Yongjun Zhang !
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703135/HDFS-7857.001.patch
          against trunk revision d1abc5d.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9784//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9784//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703135/HDFS-7857.001.patch against trunk revision d1abc5d. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9784//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9784//console This message is automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Jing Zhao,

          I submitted patch 001, would you please help taking a look when convenient? thanks a lot.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Jing Zhao , I submitted patch 001, would you please help taking a look when convenient? thanks a lot.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Jing Zhao,

          Thanks for your earlier work at HDFS-5322. What I was thinking here is, we can add information of getCauseForInvalidToken(e) to the AUDITLOG.warn message above. And probably add a debug message to print out the stack trace when debug is enabled. Any comment is welcome. Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Jing Zhao , Thanks for your earlier work at HDFS-5322 . What I was thinking here is, we can add information of getCauseForInvalidToken(e) to the AUDITLOG.warn message above. And probably add a debug message to print out the stack trace when debug is enabled. Any comment is welcome. Thanks.

            People

            • Assignee:
              yzhangal Yongjun Zhang
              Reporter:
              yzhangal Yongjun Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development