Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FileUtil#copyMerge is currently unused in the Hadoop source tree. In branch-1, it had been part of the implementation of the hadoop fs -getmerge shell command. In branch-2, the code for that shell command was rewritten in a way that no longer requires this method.

      Please check more details here..

      https://issues.apache.org/jira/browse/HADOOP-11392?focusedCommentId=14339336&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14339336

      1. HADOOP-11661-branch-2-002.patch
        2 kB
        Brahma Reddy Battula
      2. HADOOP-11661-003-branch-2.patch
        2 kB
        Brahma Reddy Battula
      3. HADOOP-11661-002.patch
        2 kB
        Brahma Reddy Battula
      4. HADOOP-11661.patch
        0.7 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12701967/HADOOP-11661.patch
          against trunk revision ca1c00b.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javac. The applied patch generated 1152 javac compiler warnings (more than the trunk's current 1151 warnings).

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5816//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5816//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5816//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701967/HADOOP-11661.patch against trunk revision ca1c00b. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac . The applied patch generated 1152 javac compiler warnings (more than the trunk's current 1151 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5816//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5816//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5816//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12701986/HADOOP-11661-002.patch
          against trunk revision ca1c00b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5817//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5817//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701986/HADOOP-11661-002.patch against trunk revision ca1c00b. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5817//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5817//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Chris Nauroth can you please review ..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Chris Nauroth can you please review ..?
          Hide
          wheat9 Haohui Mai added a comment -

          Brahma Reddy Battula can you please rebase the patch and file a follow-up jira to remove the methods in trunk? Thanks

          Show
          wheat9 Haohui Mai added a comment - Brahma Reddy Battula can you please rebase the patch and file a follow-up jira to remove the methods in trunk? Thanks
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Haohui Mai thanks a lot for taking a look into this issue..Uploaded the patch..will raise separate jira to removal from trunk..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Haohui Mai thanks a lot for taking a look into this issue..Uploaded the patch..will raise separate jira to removal from trunk..
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 49s trunk passed
          +1 compile 8m 3s trunk passed with JDK v1.8.0_66
          +1 compile 8m 43s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 37s the patch passed
          +1 compile 8m 21s the patch passed with JDK v1.8.0_66
          +1 javac 8m 21s the patch passed
          +1 compile 8m 42s the patch passed with JDK v1.7.0_85
          +1 javac 8m 42s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_85
          +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          71m 10s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774646/HADOOP-11661-003.patch
          JIRA Issue HADOOP-11661
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a6b59ae938bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9f256d1
          findbugs v3.0.0
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8162/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8162/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 49s trunk passed +1 compile 8m 3s trunk passed with JDK v1.8.0_66 +1 compile 8m 43s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 37s the patch passed +1 compile 8m 21s the patch passed with JDK v1.8.0_66 +1 javac 8m 21s the patch passed +1 compile 8m 42s the patch passed with JDK v1.7.0_85 +1 javac 8m 42s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_85 +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 71m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774646/HADOOP-11661-003.patch JIRA Issue HADOOP-11661 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a6b59ae938bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f256d1 findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8162/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8162/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 35s trunk passed
          +1 compile 10m 11s trunk passed with JDK v1.8.0_66
          +1 compile 9m 53s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 6s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 13s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 41s the patch passed
          +1 compile 10m 15s the patch passed with JDK v1.8.0_66
          +1 javac 10m 15s the patch passed
          +1 compile 9m 49s the patch passed with JDK v1.7.0_85
          +1 javac 9m 49s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 1m 7s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 13s the patch passed with JDK v1.7.0_85
          +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 7m 46s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          80m 6s



          Reason Tests
          JDK v1.7.0_85 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.ipc.TestDecayRpcScheduler
            hadoop.metrics2.impl.TestMetricsSystemImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774647/HADOOP-11661-003-branch-2.patch
          JIRA Issue HADOOP-11661
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 04d70e9bf4f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9f256d1
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 35s trunk passed +1 compile 10m 11s trunk passed with JDK v1.8.0_66 +1 compile 9m 53s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 6s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 13s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 41s the patch passed +1 compile 10m 15s the patch passed with JDK v1.8.0_66 +1 javac 10m 15s the patch passed +1 compile 9m 49s the patch passed with JDK v1.7.0_85 +1 javac 9m 49s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 13s the patch passed with JDK v1.7.0_85 +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 7m 46s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 80m 6s Reason Tests JDK v1.7.0_85 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.ipc.TestDecayRpcScheduler   hadoop.metrics2.impl.TestMetricsSystemImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774647/HADOOP-11661-003-branch-2.patch JIRA Issue HADOOP-11661 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 04d70e9bf4f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f256d1 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8164/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          Please file the following jira. It works best if these two jiras are reviewed and committed at the same time.

          Show
          wheat9 Haohui Mai added a comment - Please file the following jira. It works best if these two jiras are reviewed and committed at the same time.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          There is discussion about this in HDFS-8060..Once before raising pinging Chris Nauroth ..

          Show
          brahmareddy Brahma Reddy Battula added a comment - There is discussion about this in HDFS-8060 ..Once before raising pinging Chris Nauroth ..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Rebased the patch and raised HADOOP-12967 to removal..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Rebased the patch and raised HADOOP-12967 to removal..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 20s branch-2 passed
          +1 compile 8m 23s branch-2 passed with JDK v1.8.0_77
          +1 compile 7m 38s branch-2 passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s branch-2 passed
          +1 mvnsite 0m 59s branch-2 passed
          +1 mvneclipse 0m 13s branch-2 passed
          +1 findbugs 1m 39s branch-2 passed
          +1 javadoc 1m 3s branch-2 passed with JDK v1.8.0_77
          +1 javadoc 1m 11s branch-2 passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 7m 46s the patch passed with JDK v1.8.0_77
          +1 javac 7m 46s the patch passed
          +1 compile 7m 31s the patch passed with JDK v1.7.0_95
          +1 javac 7m 31s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 55s the patch passed
          +1 javadoc 1m 20s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95
          +1 unit 11m 23s hadoop-common in the patch passed with JDK v1.8.0_77.
          -1 unit 9m 51s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          74m 17s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:babe025
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795495/HADOOP-11661-branch-2-002.patch
          JIRA Issue HADOOP-11661
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1590c57772c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ae98314
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 20s branch-2 passed +1 compile 8m 23s branch-2 passed with JDK v1.8.0_77 +1 compile 7m 38s branch-2 passed with JDK v1.7.0_95 +1 checkstyle 0m 21s branch-2 passed +1 mvnsite 0m 59s branch-2 passed +1 mvneclipse 0m 13s branch-2 passed +1 findbugs 1m 39s branch-2 passed +1 javadoc 1m 3s branch-2 passed with JDK v1.8.0_77 +1 javadoc 1m 11s branch-2 passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 7m 46s the patch passed with JDK v1.8.0_77 +1 javac 7m 46s the patch passed +1 compile 7m 31s the patch passed with JDK v1.7.0_95 +1 javac 7m 31s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 55s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95 +1 unit 11m 23s hadoop-common in the patch passed with JDK v1.8.0_77. -1 unit 9m 51s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 74m 17s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795495/HADOOP-11661-branch-2-002.patch JIRA Issue HADOOP-11661 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1590c57772c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ae98314 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8933/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Testcase failures are unrelated and

          Patch generated 1 ASF License warnings.

          ASF warning is indtroduced by HDFS-9005. Comment about this ASF Warning.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated and Patch generated 1 ASF License warnings. ASF warning is indtroduced by HDFS-9005 . Comment about this ASF Warning.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1

          Show
          ajisakaa Akira Ajisaka added a comment - +1
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks Brahma Reddy Battula and Haohui Mai!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Brahma Reddy Battula and Haohui Mai !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9539 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9539/)
          HADOOP-11661. Deprecate FileUtil#copyMerge. Contributed by Brahma Reddy (aajisaka: rev a8d8b80a205c78bf0aa65d32a6a83c16d3ea3f0b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9539 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9539/ ) HADOOP-11661 . Deprecate FileUtil#copyMerge. Contributed by Brahma Reddy (aajisaka: rev a8d8b80a205c78bf0aa65d32a6a83c16d3ea3f0b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka thanks for review and commit. and thanks to haohui Mai for additional review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for review and commit. and thanks to haohui Mai for additional review..

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development