[HADOOP-11659] o.a.h.fs.FileSystem.Cache#remove should use a single hash map lookup

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: fs
• Hadoop Flags: Reviewed
• Assignee: Brahma Reddy Battula
• Reporter: Gera Shegalov
• Created: 02/Mar/15 09:37
• Updated: 30/Aug/16 01:30
• Resolved: 18/Mar/15 06:46

Description

The method looks up the same key in the same hash map potentially 3 times

if (map.containsKey(key) && fs == map.get(key)) {
  map.remove(key)

Instead it could do a single lookup

FileSystem cachedFs = map.remove(key);

and then test cachedFs == fs or something else.