Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11595

Add default implementation for AbstractFileSystem#truncate

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.7.0
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      As Chris Nauroth commented in HADOOP-11510, we should add a default implementation for AbstractFileSystem#truncate to avoid backwards-compatibility

        Issue Links

          Activity

          Hide
          hitliuyi Yi Liu added a comment -

          The patch also remove the truncate overwrite in TestAfsCheckPath since we have default implementation.

          Show
          hitliuyi Yi Liu added a comment - The patch also remove the truncate overwrite in TestAfsCheckPath since we have default implementation.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12699018/HADOOP-11595.001.patch
          against trunk revision ab0b958.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5705//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5705//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699018/HADOOP-11595.001.patch against trunk revision ab0b958. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5705//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5705//console This message is automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the patch. I also manually verified TestHDFSFileContextMainOperations in hadoop-hdfs, since Jenkins wouldn't have run those tests for a patch that only contains hadoop-common changes. Thank you, Yi.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the patch. I also manually verified TestHDFSFileContextMainOperations in hadoop-hdfs, since Jenkins wouldn't have run those tests for a patch that only contains hadoop-common changes. Thank you, Yi.
          Hide
          hitliuyi Yi Liu added a comment -

          Chris, Thank you very much for the review and verification!
          Sorry for late response (I am on holiday this week for Chinese traditional new year), will commit it later.

          Show
          hitliuyi Yi Liu added a comment - Chris, Thank you very much for the review and verification! Sorry for late response (I am on holiday this week for Chinese traditional new year), will commit it later.
          Hide
          hitliuyi Yi Liu added a comment -

          Committed to trunk and branch-2, thanks again Chris.

          Show
          hitliuyi Yi Liu added a comment - Committed to trunk and branch-2, thanks again Chris.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7154 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7154/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7154 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7154/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #843 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/843/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #843 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/843/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #109 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/109/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #109 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/109/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2041 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2041/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2041 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2041/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/100/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #100 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/100/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #110 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/110/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #110 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/110/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2060 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2060/)
          HADOOP-11595. Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2060 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2060/ ) HADOOP-11595 . Add default implementation for AbstractFileSystem#truncate. (yliu) (yliu: rev 64a83756350d9d0f07b72c84f2719e82cf78ee49) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestAfsCheckPath.java
          Hide
          cnauroth Chris Nauroth added a comment -

          No problem. Thank you again, Yi!

          Show
          cnauroth Chris Nauroth added a comment - No problem. Thank you again, Yi!

            People

            • Assignee:
              hitliuyi Yi Liu
              Reporter:
              hitliuyi Yi Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development