Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11491

HarFs incorrectly declared as requiring an authority

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HarFs is inited with authorityRequired=true. However, obviously har uri may contain no authority (for the underlying default file system).

      Caused by: org.apache.hadoop.HadoopIllegalArgumentException: FileSystem implementation error -  default port -1 is not valid
      	at org.apache.hadoop.fs.AbstractFileSystem.getUri(AbstractFileSystem.java:301)
      	at org.apache.hadoop.fs.AbstractFileSystem.<init>(AbstractFileSystem.java:261)
      	at org.apache.hadoop.fs.DelegateToFileSystem.<init>(DelegateToFileSystem.java:49)
      	at org.apache.hadoop.fs.HarFs.<init>(HarFs.java:30)
      	... 17 more
      

      and the HDFS HA URI's must not have ports either.

      1. HADOOP-11491.patch
        0.8 kB
        Brahma Reddy Battula
      2. HADOOP-11491-002.patch
        2 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Marked as critical as harfs will not able to usable when HDFS cluster installed in HA mode ( As it will defined like hdfs://hacluster , which will not get resolved.)..
        Attached initial patch.. Thinking of adding test case in Testharfilesystem or create new testclass ( testharfs).. Gera Shegalov can you please give your input..Thanks..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Marked as critical as harfs will not able to usable when HDFS cluster installed in HA mode ( As it will defined like hdfs://hacluster , which will not get resolved.).. Attached initial patch.. Thinking of adding test case in Testharfilesystem or create new testclass ( testharfs).. Gera Shegalov can you please give your input..Thanks..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 40s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 55s There were no new javac warning messages.
        +1 javadoc 9m 48s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 5m 29s There were no new checkstyle issues.
        +1 install 1m 41s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 45s Tests passed in hadoop-common.
            68m 2s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729222/HADOOP-11491.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8f82970
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6216/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6216/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6216/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 29s There were no new checkstyle issues. +1 install 1m 41s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 45s Tests passed in hadoop-common.     68m 2s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729222/HADOOP-11491.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8f82970 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6216/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6216/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6216/console This message was automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Thanks for the patch, Brahma Reddy Battula! Please add this small test to TestHarFileSystemBasics:

          @Test
          public void testHarFsWithoutAuthority() throws Exception {
            final URI uri = harFileSystem.getUri();
            Assert.assertNull("har uri not null: " + uri, uri.getAuthority());
            FileContext.getFileContext(uri, conf);
          }
        
        Show
        jira.shegalov Gera Shegalov added a comment - Thanks for the patch, Brahma Reddy Battula ! Please add this small test to TestHarFileSystemBasics : @Test public void testHarFsWithoutAuthority() throws Exception { final URI uri = harFileSystem.getUri(); Assert.assertNull( "har uri not null : " + uri, uri.getAuthority()); FileContext.getFileContext(uri, conf); }
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Gera Shegalov Thanks a lot for your input..Attached patch based on your comment..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Gera Shegalov Thanks a lot for your input..Attached patch based on your comment..
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 2s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 24m 4s Tests passed in hadoop-common.
            60m 55s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729789/HADOOP-11491-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 279958b
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6239/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6239/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6239/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 2s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 24m 4s Tests passed in hadoop-common.     60m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729789/HADOOP-11491-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 279958b hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6239/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6239/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6239/console This message was automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        +1, will just fix my typo. Should have been "har uri authority not null".

        Show
        jira.shegalov Gera Shegalov added a comment - +1, will just fix my typo. Should have been "har uri authority not null".
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #7716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7716/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #7716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7716/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Thanks Brahma Reddy Battula for contribution! Committed to trunk and branch-2.

        Show
        jira.shegalov Gera Shegalov added a comment - Thanks Brahma Reddy Battula for contribution! Committed to trunk and branch-2.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks a lot Gera Shegalov!!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks a lot Gera Shegalov !!!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/181/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/181/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #915 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/915/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #915 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/915/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/172/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/172/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2113 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2113/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2113 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2113/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/182/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/182/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2131/)
        HADOOP-11491. HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2131/ ) HADOOP-11491 . HarFs incorrectly declared as requiring an authority. (Brahma Reddy Battula via gera) (gera: rev f343f8657e2b01773a32c2c7d960dc368954b42e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/HarFs.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystemBasics.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Pulled this into 2.6.1 after Akira Ajisaka verified that the patch applies cleanly. Ran compilation and TestHarFileSystemBasics before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1 after Akira Ajisaka verified that the patch applies cleanly. Ran compilation and TestHarFileSystemBasics before the push.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1.

        branch-2 patch applies cleanly. Ran compilation and TestHarFileSystemBasics before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1. branch-2 patch applies cleanly. Ran compilation and TestHarFileSystemBasics before the push.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            jira.shegalov Gera Shegalov
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development