[HADOOP-11430] Add GenericTestUtils#disableLog, GenericTestUtils#setLogLevel

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Target Version/s: 2.7.0
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 18/Dec/14 22:46
• Updated: 31/Jul/15 22:34
• Resolved: 19/Dec/14 03:42

Description

Now that we are using both commons-logging and slf4j, we can no longer rely on just casting the Log object to a Log4JLogger and calling setLevel on that. With org.slf4j.Logger objects, we need to look up the underlying Log4JLogger using LogManager#getLogger.

This patch adds GenericTestUtils#disableLog and GenericTestUtils#setLogLevel functions which hide this complexity from unit tests, just allowing the tests to call disableLog or setLogLevel, and have GenericTestUtils figure out the right thing to do based on the log / logger type.

Issue Links

• relates to: HDFS-6860 BlockStateChange logs are too noisy