[HADOOP-11414] FileBasedIPList#readLines() can leak file descriptors

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Tsuyoshi Ozawa
• Reporter: Ted Yu
• Created: 16/Dec/14 22:46
• Updated: 24/Apr/15 22:49
• Resolved: 22/Dec/14 04:13

Description

          Reader fileReader = new InputStreamReader(
              new FileInputStream(file), Charsets.UTF_8);
          BufferedReader bufferedReader = new BufferedReader(fileReader);
          List<String> lines = new ArrayList<String>();
          String line = null;
          while ((line = bufferedReader.readLine()) != null) {
            lines.add(line);
          }
          bufferedReader.close();

Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader should be enclosed within finally block.