Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.7.0
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      YARN-2875 highllights some problems with SLF4J 1.7.5; needs to be pulled up to 1.7.7;

      1. HADOOP-11317.patch
        0.8 kB
        Tim Robertson

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2020 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2020/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2020 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2020/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #85 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/85/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #85 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/85/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #822 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/822/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #822 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/822/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #88 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/88/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #88 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/88/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2038 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2038/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2038 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2038/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #88 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/88/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #88 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/88/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6950 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6950/)
          HADOOP-11317. Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6950 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6950/ ) HADOOP-11317 . Increment SLF4J version to 1.7.10. Contributed by Tim Robertson. (ozawa: rev 20a4768397a36a21a6e6d9b27b5a81898a5889d9) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Tim for your contribution and thanks Steve for your review and report.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Tim for your contribution and thanks Steve for your review and report.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 from me

          Show
          stevel@apache.org Steve Loughran added a comment - +1 from me
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          The current assignee is Steve, so I'll wait for his comment before committing.

          Show
          ozawa Tsuyoshi Ozawa added a comment - The current assignee is Steve, so I'll wait for his comment before committing.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          +1

          Show
          ozawa Tsuyoshi Ozawa added a comment - +1
          Hide
          timrobertson100 Tim Robertson added a comment -

          Justification: No unit tests were added as this was a version bump to bring in methods missing the log4j SLF4J bridge. It is only to ease the use for those folks shipping log4j through SLF.

          Manual steps taken were only to ensure that it compiled - unit tests for HDFS would not run on my environment (with or without this patch) for reasons currently unknown - each test run is 8hr+ though so slow progress...

          Show
          timrobertson100 Tim Robertson added a comment - Justification: No unit tests were added as this was a version bump to bring in methods missing the log4j SLF4J bridge. It is only to ease the use for those folks shipping log4j through SLF. Manual steps taken were only to ensure that it compiled - unit tests for HDFS would not run on my environment (with or without this patch) for reasons currently unknown - each test run is 8hr+ though so slow progress...
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12694952/HADOOP-11317.patch
          against trunk revision d12dd47.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5515//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5515//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12694952/HADOOP-11317.patch against trunk revision d12dd47. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5515//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5515//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Submitting a patch.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Submitting a patch.
          Hide
          timrobertson100 Tim Robertson added a comment -

          When this issue was created 1.7.7 was the latest 1.7 branch, but looking at http://www.slf4j.org/news.html I see no reason not to bump to 1.7.10. Attaching a patch to do just

          Show
          timrobertson100 Tim Robertson added a comment - When this issue was created 1.7.7 was the latest 1.7 branch, but looking at http://www.slf4j.org/news.html I see no reason not to bump to 1.7.10. Attaching a patch to do just

            People

            • Assignee:
              timrobertson100 Tim Robertson
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development