Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11284

Fix variable name mismatches in hadoop-functions.sh

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None

      Description

      Some functions use variables not given as argument but defined in outside of function. The variables are used as name of pid file. Though hadoop-functions.sh works by chance now, it should be fixed to avoid future bug.

      1. HADOOP-11284.1.patch
        2 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/4/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/4/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1956 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1956/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1956 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1956/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1932 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1932/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1932 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1932/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/4/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/4/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #742 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/742/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #742 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/742/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/4/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/4/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6526 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6526/)
          HADOOP-11284. Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6526 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6526/ ) HADOOP-11284 . Fix variable name mismatches in hadoop-functions.sh (Masatake Iwasaki via aw) (aw: rev d7150a1bc2fdf87bedb112ffbd1c5cab7f14d1c3) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          aw Allen Wittenauer added a comment -

          Committed to trunk.

          Thanks!

          Show
          aw Allen Wittenauer added a comment - Committed to trunk. Thanks!
          Hide
          aw Allen Wittenauer added a comment -

          Ugh. I really messed these up.

          Thanks for finding them.

          +1 will commit to trunk.

          Show
          aw Allen Wittenauer added a comment - Ugh. I really messed these up. Thanks for finding them. +1 will commit to trunk.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I tested the patch on my local. PID file is properly created and deleted for both of non-secure and secure datanode.

          Show
          iwasakims Masatake Iwasaki added a comment - I tested the patch on my local. PID file is properly created and deleted for both of non-secure and secure datanode.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          This patch also fixes typo in log messages.

          Show
          iwasakims Masatake Iwasaki added a comment - This patch also fixes typo in log messages.

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development