Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11149

Increase the timeout of TestZKFailoverController

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      Jenkins

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Running org.apache.hadoop.ha.TestZKFailoverController
      Tests run: 19, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 56.875 sec <<< FAILURE! - in org.apache.hadoop.ha.TestZKFailoverController
      testGracefulFailover(org.apache.hadoop.ha.TestZKFailoverController)  Time elapsed: 25.045 sec  <<< ERROR!
      java.lang.Exception: test timed out after 25000 milliseconds
      	at java.lang.Object.wait(Native Method)
      	at org.apache.hadoop.ha.ZKFailoverController.waitForActiveAttempt(ZKFailoverController.java:467)
      	at org.apache.hadoop.ha.ZKFailoverController.doGracefulFailover(ZKFailoverController.java:657)
      	at org.apache.hadoop.ha.ZKFailoverController.access$400(ZKFailoverController.java:61)
      	at org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:602)
      	at org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:599)
      	at java.security.AccessController.doPrivileged(Native Method)
      	at javax.security.auth.Subject.doAs(Subject.java:415)
      	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1621)
      	at org.apache.hadoop.ha.ZKFailoverController.gracefulFailoverToYou(ZKFailoverController.java:599)
      	at org.apache.hadoop.ha.ZKFCRpcServer.gracefulFailover(ZKFCRpcServer.java:94)
      	at org.apache.hadoop.ha.TestZKFailoverController.testGracefulFailover(TestZKFailoverController.java:448)
      
      
      Results :
      
      Tests in error:
        TestZKFailoverController.testGracefulFailover:448->Object.wait:-2 »  test time...
      

      Running on centos6.5

      1. HADOOP-11149-001.patch
        30 kB
        Steve Loughran
      2. HADOOP-11149-002.patch
        31 kB
        Steve Loughran

        Activity

        Hide
        praste Pushkar Raste added a comment -

        I am running into same issue on Ubuntu

        Show
        praste Pushkar Raste added a comment - I am running into same issue on Ubuntu
        Hide
        stevel@apache.org Steve Loughran added a comment -

        surfacing again on jenkins

        java.lang.Exception: test timed out after 25000 milliseconds
        	at java.lang.Object.wait(Native Method)
        	at org.apache.hadoop.ha.ZKFailoverController.waitForActiveAttempt(ZKFailoverController.java:472)
        	at org.apache.hadoop.ha.ZKFailoverController.doGracefulFailover(ZKFailoverController.java:679)
        	at org.apache.hadoop.ha.ZKFailoverController.access$400(ZKFailoverController.java:62)
        	at org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:607)
        	at org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:604)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:415)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1667)
        	at org.apache.hadoop.ha.ZKFailoverController.gracefulFailoverToYou(ZKFailoverController.java:604)
        	at org.apache.hadoop.ha.ZKFCRpcServer.gracefulFailover(ZKFCRpcServer.java:94)
        	at org.apache.hadoop.ha.TestZKFailoverController.testGracefulFailover(TestZKFailoverController.java:448)
        
        Show
        stevel@apache.org Steve Loughran added a comment - surfacing again on jenkins java.lang.Exception: test timed out after 25000 milliseconds at java.lang. Object .wait(Native Method) at org.apache.hadoop.ha.ZKFailoverController.waitForActiveAttempt(ZKFailoverController.java:472) at org.apache.hadoop.ha.ZKFailoverController.doGracefulFailover(ZKFailoverController.java:679) at org.apache.hadoop.ha.ZKFailoverController.access$400(ZKFailoverController.java:62) at org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:607) at org.apache.hadoop.ha.ZKFailoverController$3.run(ZKFailoverController.java:604) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1667) at org.apache.hadoop.ha.ZKFailoverController.gracefulFailoverToYou(ZKFailoverController.java:604) at org.apache.hadoop.ha.ZKFCRpcServer.gracefulFailover(ZKFCRpcServer.java:94) at org.apache.hadoop.ha.TestZKFailoverController.testGracefulFailover(TestZKFailoverController.java:448)
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Note that the test is being killed in JUnit as the test hangs, It's doing that as the failover is spinning for 60s in ZKFailoverController.doGracefulFailover()

        waitForActiveAttempt(timeout + 60000);
        

        It may be that the test is working, but the 25s timeout is too short. Setting it to 120000 millis would ensure that the test at least failed with a meaningful exception raised from the ZKFailoverController.

        Show
        stevel@apache.org Steve Loughran added a comment - Note that the test is being killed in JUnit as the test hangs, It's doing that as the failover is spinning for 60s in ZKFailoverController.doGracefulFailover() waitForActiveAttempt(timeout + 60000); It may be that the test is working, but the 25s timeout is too short. Setting it to 120000 millis would ensure that the test at least failed with a meaningful exception raised from the ZKFailoverController.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Actually TestZKFailoverController is more broken than you'd think. Most of the tests don't run as they lack the Java4 @Test annotation

        Show
        stevel@apache.org Steve Loughran added a comment - Actually TestZKFailoverController is more broken than you'd think. Most of the tests don't run as they lack the Java4 @Test annotation
        Hide
        stevel@apache.org Steve Loughran added a comment -

        (ignore that last comment)

        Show
        stevel@apache.org Steve Loughran added a comment - (ignore that last comment)
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Patch --001.

        1. Adds a Test rule giving all tests a timeout of 3 minutes
        2. culls the various timeouts attached to specific tests for a uniform value.
        3. removes the try/finally cleanup logic for cluster.stop, instead putting it into an @After method, so guaranteeing the cluster gets stopped even on a test timeout failure.
        Show
        stevel@apache.org Steve Loughran added a comment - Patch --001. Adds a Test rule giving all tests a timeout of 3 minutes culls the various timeouts attached to specific tests for a uniform value. removes the try/finally cleanup logic for cluster.stop , instead putting it into an @After method, so guaranteeing the cluster gets stopped even on a test timeout failure.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 7m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 46s There were no new javac warning messages.
        -1 release audit 0m 18s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 3s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 6m 44s Tests passed in hadoop-common.
            27m 8s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765984/HADOOP-11149-001.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 7e2c971
        Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 46s There were no new javac warning messages. -1 release audit 0m 18s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 3s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 6m 44s Tests passed in hadoop-common.     27m 8s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765984/HADOOP-11149-001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 7e2c971 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7793/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        The RAT test should have been fixed by HDFS-9215; if this isn't taking then I'll re-open that

        Show
        stevel@apache.org Steve Loughran added a comment - The RAT test should have been fixed by HDFS-9215 ; if this isn't taking then I'll re-open that
        Hide
        vinayrpet Vinayakumar B added a comment -

        Adding rule for all tests and unifying the @After method is good.

        Just one comment,
        Some tests, not even start the cluster. For such tests, @After method will log NPE. I think simple null check inside MiniZKFCCluster.stop would be better,

        2015-10-16 15:36:47,043 WARN  ha.ClientBaseWithFixes (TestZKFailoverController.java:teardown(92)) - When stopping the cluster
        java.lang.NullPointerException
        	at org.apache.hadoop.ha.MiniZKFCCluster.stop(MiniZKFCCluster.java:136)
        	at org.apache.hadoop.ha.TestZKFailoverController.teardown(TestZKFailoverController.java:90)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

        Rest looks good.

        Show
        vinayrpet Vinayakumar B added a comment - Adding rule for all tests and unifying the @After method is good. Just one comment, Some tests, not even start the cluster. For such tests, @After method will log NPE. I think simple null check inside MiniZKFCCluster.stop would be better, 2015-10-16 15:36:47,043 WARN ha.ClientBaseWithFixes (TestZKFailoverController.java:teardown(92)) - When stopping the cluster java.lang.NullPointerException at org.apache.hadoop.ha.MiniZKFCCluster.stop(MiniZKFCCluster.java:136) at org.apache.hadoop.ha.TestZKFailoverController.teardown(TestZKFailoverController.java:90) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) Rest looks good.
        Hide
        wheat9 Haohui Mai added a comment -

        Do you think it makes sense to reduce the timeouts of the ZKFC so that the test can run faster as well.

        Show
        wheat9 Haohui Mai added a comment - Do you think it makes sense to reduce the timeouts of the ZKFC so that the test can run faster as well.
        Hide
        stevel@apache.org Steve Loughran added a comment -
        1. yes, we should add a check for null in zk shutdown
        2. Haohui, anything which reduces test times without triggering false failures would be welcome. I'll let you suggest those as a followup
        Show
        stevel@apache.org Steve Loughran added a comment - yes, we should add a check for null in zk shutdown Haohui, anything which reduces test times without triggering false failures would be welcome. I'll let you suggest those as a followup
        Hide
        stevel@apache.org Steve Loughran added a comment -

        patch -002 adds the check for null in the stop() method

        Show
        stevel@apache.org Steve Loughran added a comment - patch -002 adds the check for null in the stop() method
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user steveloughran opened a pull request:

        https://github.com/apache/hadoop/pull/51

        HADOOP-11149

        zk failover controller test improvements -maybe this'll stop jenkins failing so often

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/steveloughran/hadoop jenkins/HADOOP-11149-ZKFailoverController

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/hadoop/pull/51.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #51


        commit be684eff15d8c055aca10ef0fe90be82f74d84cf
        Author: Steve Loughran <stevel@hortonworks.com>
        Date: 2015-10-10T12:05:26Z

        HADOOP-11149 TestZKFailoverController times out patch 001

        commit 6ede0842a3d4012e1e9c370cc8442c25ebd09410
        Author: Steve Loughran <stevel@hortonworks.com>
        Date: 2015-10-26T20:20:04Z

        HADOOP-11149-002: MiniZKFCCluster stop() robust against NPE


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user steveloughran opened a pull request: https://github.com/apache/hadoop/pull/51 HADOOP-11149 zk failover controller test improvements -maybe this'll stop jenkins failing so often You can merge this pull request into a Git repository by running: $ git pull https://github.com/steveloughran/hadoop jenkins/ HADOOP-11149 -ZKFailoverController Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit be684eff15d8c055aca10ef0fe90be82f74d84cf Author: Steve Loughran <stevel@hortonworks.com> Date: 2015-10-10T12:05:26Z HADOOP-11149 TestZKFailoverController times out patch 001 commit 6ede0842a3d4012e1e9c370cc8442c25ebd09410 Author: Steve Loughran <stevel@hortonworks.com> Date: 2015-10-26T20:20:04Z HADOOP-11149 -002: MiniZKFCCluster stop() robust against NPE
        Hide
        ozawa Tsuyoshi Ozawa added a comment - - edited

        +1, after Jenkins passes, checking this in.

        Show
        ozawa Tsuyoshi Ozawa added a comment - - edited +1, after Jenkins passes, checking this in.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 9m 8s trunk passed
        +1 compile 10m 40s trunk passed with JDK v1.8.0_66
        +1 compile 10m 20s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 1m 8s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 8s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 12s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 43s the patch passed
        +1 compile 9m 56s the patch passed with JDK v1.8.0_66
        +1 javac 9m 56s the patch passed
        +1 compile 10m 2s the patch passed with JDK v1.7.0_85
        +1 javac 10m 2s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 1m 12s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 16s the patch passed
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 17s the patch passed with JDK v1.7.0_85
        -1 unit 8m 54s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 8m 26s hadoop-common in the patch failed with JDK v1.7.0_85.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        83m 20s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.ipc.TestIPC
        JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.fs.shell.TestCopyPreserveFlag
          hadoop.ipc.TestIPC



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Issue HADOOP-11149
        GITHUB PR https://github.com/apache/hadoop/pull/51
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 88d0e2a3c278 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a6f20d8
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/console
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 8s trunk passed +1 compile 10m 40s trunk passed with JDK v1.8.0_66 +1 compile 10m 20s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 8s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 12s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 43s the patch passed +1 compile 9m 56s the patch passed with JDK v1.8.0_66 +1 javac 9m 56s the patch passed +1 compile 10m 2s the patch passed with JDK v1.7.0_85 +1 javac 10m 2s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_85 -1 unit 8m 54s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 26s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 83m 20s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ipc.TestIPC JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.TestCopyPreserveFlag   hadoop.ipc.TestIPC Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue HADOOP-11149 GITHUB PR https://github.com/apache/hadoop/pull/51 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 88d0e2a3c278 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a6f20d8 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/console Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8121/console This message was automatically generated.
        Hide
        wheat9 Haohui Mai added a comment -

        +1. Committing.

        Show
        wheat9 Haohui Mai added a comment - +1. Committing.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Checking this in since the patch of this issue only includes TestZKFailoverController and MiniZKFCCluster. TestGangliaMetrics, TestIPC, TestCopyPreserveFlag pass locally, and they should be tracked on another jiras.

        • TestIPC.testIpcWithReaderQueuing: reopened HADOOP-10406
        • TestGangliaMetrics: HADOOP-12588
        • TestCopyPreserveFlag: it looks like to be permission issue or timing issue. Opened HADOOP-12589
        Show
        ozawa Tsuyoshi Ozawa added a comment - Checking this in since the patch of this issue only includes TestZKFailoverController and MiniZKFCCluster. TestGangliaMetrics, TestIPC, TestCopyPreserveFlag pass locally, and they should be tracked on another jiras. TestIPC.testIpcWithReaderQueuing: reopened HADOOP-10406 TestGangliaMetrics: HADOOP-12588 TestCopyPreserveFlag: it looks like to be permission issue or timing issue. Opened HADOOP-12589
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/hadoop/pull/51

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/hadoop/pull/51
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Steve Loughran for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Steve Loughran for the contribution.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Haohui Mai FYI: I committed to trunk by using github integration: https://wiki.apache.org/hadoop/GithubIntegration. It works well Thanks you for committing to branch-2.

        Thanks Steve Loughran for the contribution!

        Show
        ozawa Tsuyoshi Ozawa added a comment - Haohui Mai FYI: I committed to trunk by using github integration: https://wiki.apache.org/hadoop/GithubIntegration . It works well Thanks you for committing to branch-2. Thanks Steve Loughran for the contribution!
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Haohui Mai oh, we crossed the git push. It can cause the conflicts against CHANGES.txt - should I revert my commit?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Haohui Mai oh, we crossed the git push . It can cause the conflicts against CHANGES.txt - should I revert my commit?
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8855 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8855/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8855 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8855/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #700 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/700/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #700 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/700/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2641 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2641/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2641 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2641/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1435 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1435/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1435 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1435/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #711 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/711/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #711 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/711/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Please ping me if something goes wrong.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Please ping me if something goes wrong.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/)
        HADOOP-11149. TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/ ) HADOOP-11149 . TestZKFailoverController times out. Contributed by Steve (ozawa: rev 053a5119197db3aef1842d1fa16c0f0872fffcac) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestZKFailoverController.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/MiniZKFCCluster.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Steve! I committed this to branch-2.7 as well.

        Show
        jlowe Jason Lowe added a comment - Thanks, Steve! I committed this to branch-2.7 as well.

          People

          • Assignee:
            stevel@apache.org Steve Loughran
            Reporter:
            rajatjain Rajat Jain
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development