Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Typing bin/hadoop fs -rmr /a?

      gives the output:

      rmr: DEPRECATED: Please use 'rm -r' instead.

      Typing bin/hadoop fs rm -r /a?

      gives the output:

      rm: Unknown command

      1. HADOOP-11120.patch
        1 kB
        Juliet Hougland
      2. Screen Shot 2014-09-24 at 3.02.21 PM.png
        39 kB
        Allen Wittenauer

        Activity

        Hide
        vinayrpet Vinayakumar B added a comment -

        I believe you might have got the full error message as below

        rm: Unknown command
        Did you mean -rm?  This command begins with a dash.

        I feel its correct. ''rmr" and "rm" are commands. And to use any commands with fsshell we should prefix them with '-'.

        Show
        vinayrpet Vinayakumar B added a comment - I believe you might have got the full error message as below rm: Unknown command Did you mean -rm? This command begins with a dash. I feel its correct. ''rmr" and "rm" are commands. And to use any commands with fsshell we should prefix them with '-'.
        Hide
        aw Allen Wittenauer added a comment -

        I believe you might have got the full error message as below

        Nope. See this screenshot. (which, as an added bonus, also features HADOOP-11119!)

        We clearly have two code paths in play, which makes this even worse.

        And to use any commands with fsshell we should prefix them with '-'.

        ...which is why we should be explicit to users about what we want them to do. Hoping they correctly guess our intentions is terrible design.

        Show
        aw Allen Wittenauer added a comment - I believe you might have got the full error message as below Nope. See this screenshot. (which, as an added bonus, also features HADOOP-11119 !) We clearly have two code paths in play, which makes this even worse. And to use any commands with fsshell we should prefix them with '-'. ...which is why we should be explicit to users about what we want them to do. Hoping they correctly guess our intentions is terrible design.
        Hide
        aw Allen Wittenauer added a comment -

        Oh, you meant with the the hadoop fs rm. Yes, I did get the condescending 'Perhaps' message.

        Show
        aw Allen Wittenauer added a comment - Oh, you meant with the the hadoop fs rm. Yes, I did get the condescending 'Perhaps' message.
        Hide
        chris.douglas Chris Douglas added a comment -

        This doesn't seem too egregious... I've never been a fan of the dash prefix, but both error messages are correct.

        The proposed fix is for for the deprecation message to include the dash prefix, so a user gets the correct command in one hop instead of two?

        Show
        chris.douglas Chris Douglas added a comment - This doesn't seem too egregious... I've never been a fan of the dash prefix, but both error messages are correct. The proposed fix is for for the deprecation message to include the dash prefix, so a user gets the correct command in one hop instead of two?
        Hide
        aw Allen Wittenauer added a comment -

        Yup. At least until we can start changing all of the commands to be sane.

        Show
        aw Allen Wittenauer added a comment - Yup. At least until we can start changing all of the commands to be sane.
        Hide
        juliet Juliet Hougland added a comment -

        Suggests that the correct replacement for the deprecates `-rmr` command is `-rm -r`, not `rm -r`

        Show
        juliet Juliet Hougland added a comment - Suggests that the correct replacement for the deprecates `-rmr` command is `-rm -r`, not `rm -r`
        Hide
        juliet Juliet Hougland added a comment -

        This should be reviewed, please.

        Show
        juliet Juliet Hougland added a comment - This should be reviewed, please.
        Hide
        juliet Juliet Hougland added a comment -

        This is a change to the deprecation message for `hadoop fs -rmr` that corrects the suggested replacement command to be `hadoop fs -rm -r`

        Show
        juliet Juliet Hougland added a comment - This is a change to the deprecation message for `hadoop fs -rmr` that corrects the suggested replacement command to be `hadoop fs -rm -r`
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12725729/HADOOP-11120.patch
        against trunk revision 1b89a3e.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6106//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725729/HADOOP-11120.patch against trunk revision 1b89a3e. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6106//console This message is automatically generated.
        Hide
        juliet Juliet Hougland added a comment -

        Hmm, looks like I need to regenerate the diff.

        Show
        juliet Juliet Hougland added a comment - Hmm, looks like I need to regenerate the diff.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12725735/HADOOP-11120.patch
        against trunk revision 1b89a3e.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.cli.TestCLI

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6107//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6107//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725735/HADOOP-11120.patch against trunk revision 1b89a3e. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.cli.TestCLI Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6107//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6107//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12725769/HADOOP-11120.patch
        against trunk revision 1b89a3e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6109//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6109//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725769/HADOOP-11120.patch against trunk revision 1b89a3e. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6109//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6109//console This message is automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the contribution here Juliet, +1 LGTM. I've committed it to trunk and branch-2 for 2.8.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the contribution here Juliet, +1 LGTM. I've committed it to trunk and branch-2 for 2.8.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7733 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7733/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7733 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7733/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/185/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/185/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/)
        HADOOP-11120. hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f)

        • hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/ ) HADOOP-11120 . hadoop fs -rmr gives wrong advice. Contributed by Juliet Houghland. (wang: rev 05adc76ace6bf28e4a3ff874044c2c41e3eba63f) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            juliet Juliet Hougland
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development