[HADOOP-11042] CryptoInputStream throwing wrong exception class on errors

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: fs
• Labels: BB2015-05-TBR
• Target Version/s: 2.8.3
• Assignee: Yi Liu
• Reporter: Steve Loughran
• Created: 01/Sep/14 11:17
• Updated: 11/Sep/17 05:11

Description

Having had a quick look at the CryptoInputStream class, it's not in sync with all the other filesystem's exception logic, as specified in src/site/markdown/filesystem/fsdatainputstream.md

Operations MUST throw an IOException on out of bounds reads, ideally EOFException :

1. read(byte[] b, int off, int len)
2. {{seek(long pos) }}
3. seekToNewSource

The tests you want to extend to verify expected behaviour are in AbstractContractOpenTest and AbstractContractSeekTest

also, the HasEnhancedByteBufferAccess implementations may want to think about using checkStream() before acting on a potentially closed stream.