Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11032

Replace use of Guava's Stopwatch with Hadoop's StopWatch

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      This patch reduces Hadoop's dependency on an old version of guava. Stopwatch.elapsedMillis() isn't part of guava past v16 and the tools I'm working on use v17.

      To remedy this and also reduce Hadoop's reliance on old versions of guava, we can implement original StopWatch based on Guava's one and Apache's one.

      1. HADOOP-11032.1.patch
        18 kB
        Tsuyoshi Ozawa
      2. HADOOP-11032.2.patch
        18 kB
        Gary Steelman
      3. HADOOP-11032.3.patch
        18 kB
        Tsuyoshi Ozawa
      4. HADOOP-11032.3.patch
        18 kB
        Gary Steelman
      5. HADOOP-11032.3.patch
        18 kB
        Gary Steelman
      6. HADOOP-11032.3.patch
        18 kB
        Tsuyoshi Ozawa
      7. HADOOP-11032.3.patch
        18 kB
        Tsuyoshi Ozawa
      8. HADOOP-11032.4.patch
        23 kB
        Tsuyoshi Ozawa
      9. HADOOP-11032.5.patch
        23 kB
        Tsuyoshi Ozawa
      10. HADOOP-11032.6.patch
        23 kB
        Tsuyoshi Ozawa
      11. HADOOP-11032.7.patch
        23 kB
        Tsuyoshi Ozawa
      12. HADOOP-11032.8.patch
        26 kB
        Tsuyoshi Ozawa
      13. HADOOP-11032.8.patch
        26 kB
        Tsuyoshi Ozawa

        Issue Links

          Activity

          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Quick prototype to replace Guava Stopwatch with Apache StopWatch.
          It can be replaced straightforwardly. One concerns is that some components use Guava Stopwatch in micro second mode, but Apache StopWatch only provides millisecond-level precision.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Quick prototype to replace Guava Stopwatch with Apache StopWatch. It can be replaced straightforwardly. One concerns is that some components use Guava Stopwatch in micro second mode, but Apache StopWatch only provides millisecond-level precision.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12665560/HADOOP-11032.1.patch
          against trunk revision 0f34e6f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
          org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
          org.apache.hadoop.hdfs.server.balancer.TestBalancer
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.hdfs.TestFileLengthOnClusterRestart

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4604//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4604//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665560/HADOOP-11032.1.patch against trunk revision 0f34e6f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.TestFileLengthOnClusterRestart +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4604//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4604//console This message is automatically generated.
          Hide
          gsteelman Gary Steelman added a comment -

          Thanks for uploading a patch Tsuyoshi Ozawa. I was working to upload mine today but you got there before me! Yes, millisecond precision is one concern and there are some existing places which expect microsecond values. These values are expected to be on the order of 10^3 larger than the millisecond value returned by Stopwatch.getTime(). In this case we can use TimeUnit to convert, since TimeUnit is already part of the code:

          TimeUnit.MICROSECONDS.convert(sw.getTime(), TimeUnit.MILLISECONDS);

          I will upload a second patch shortly with a couple changes from your patch

          Show
          gsteelman Gary Steelman added a comment - Thanks for uploading a patch Tsuyoshi Ozawa . I was working to upload mine today but you got there before me! Yes, millisecond precision is one concern and there are some existing places which expect microsecond values. These values are expected to be on the order of 10^3 larger than the millisecond value returned by Stopwatch.getTime(). In this case we can use TimeUnit to convert, since TimeUnit is already part of the code: TimeUnit.MICROSECONDS.convert(sw.getTime(), TimeUnit.MILLISECONDS); I will upload a second patch shortly with a couple changes from your patch
          Hide
          gsteelman Gary Steelman added a comment -

          Uploaded a new patch with microsecond conversion where necessary.

          Show
          gsteelman Gary Steelman added a comment - Uploaded a new patch with microsecond conversion where necessary.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12665560/HADOOP-11032.1.patch
          against trunk revision 0f34e6f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel
          org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4606//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4606//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665560/HADOOP-11032.1.patch against trunk revision 0f34e6f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4606//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4606//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12665576/HADOOP-11032.2.patch
          against trunk revision 0f34e6f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.util.TestDataChecksum
          org.apache.hadoop.mapreduce.lib.input.TestLineRecordReader
          org.apache.hadoop.mapred.TestLineRecordReader
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4607//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4607//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665576/HADOOP-11032.2.patch against trunk revision 0f34e6f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.util.TestDataChecksum org.apache.hadoop.mapreduce.lib.input.TestLineRecordReader org.apache.hadoop.mapred.TestLineRecordReader org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4607//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4607//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Thanks for updating patch, Gary. Some of these test failures are related to our work - Apache StopWatch#stop() raises IllegalStateException if we call the method twice. I'll update it to fix.

          java.lang.IllegalStateException: Stopwatch is not running.
          at org.apache.commons.lang.time.StopWatch.stop(StopWatch.java:142)
          at org.apache.hadoop.util.TestDataChecksum.commonUsagePerfTest(TestDataChecksum.java:160)

          Show
          ozawa Tsuyoshi Ozawa added a comment - Thanks for updating patch, Gary. Some of these test failures are related to our work - Apache StopWatch#stop() raises IllegalStateException if we call the method twice. I'll update it to fix. java.lang.IllegalStateException: Stopwatch is not running. at org.apache.commons.lang.time.StopWatch.stop(StopWatch.java:142) at org.apache.hadoop.util.TestDataChecksum.commonUsagePerfTest(TestDataChecksum.java:160)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12665713/HADOOP-11032.3.patch
          against trunk revision 258c7d0.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.hdfs.TestHDFSFileSystemContract
          org.apache.hadoop.hdfs.TestEncryptedTransfer
          org.apache.hadoop.hdfs.TestRollingUpgrade
          org.apache.hadoop.hdfs.web.TestWebHDFSForHA
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
          org.apache.hadoop.TestGenericRefresh
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractSeek
          org.apache.hadoop.hdfs.TestPread
          org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs
          org.apache.hadoop.hdfs.crypto.TestHdfsCryptoStreams
          org.apache.hadoop.hdfs.TestWriteBlockGetsBlockLengthHint
          org.apache.hadoop.fs.TestSymlinkHdfsDisable
          org.apache.hadoop.hdfs.TestDecommission
          org.apache.hadoop.hdfs.TestDFSRemove
          org.apache.hadoop.cli.TestCacheAdminCLI
          org.apache.hadoop.fs.loadGenerator.TestLoadGenerator
          org.apache.hadoop.hdfs.TestFileAppend4
          org.apache.hadoop.security.TestPermission
          org.apache.hadoop.hdfs.TestDFSShell
          org.apache.hadoop.hdfs.web.TestWebHDFSXAttr
          org.apache.hadoop.hdfs.TestModTime
          org.apache.hadoop.hdfs.TestBlockReaderLocalLegacy
          org.apache.hadoop.hdfs.web.TestWebHDFS
          org.apache.hadoop.hdfs.TestDatanodeConfig
          org.apache.hadoop.hdfs.TestDFSUpgrade
          org.apache.hadoop.hdfs.TestParallelRead
          org.apache.hadoop.security.TestPermissionSymlinks
          org.apache.hadoop.hdfs.tools.TestDFSHAAdminMiniCluster
          org.apache.hadoop.fs.viewfs.TestViewFsWithAcls
          org.apache.hadoop.hdfs.TestParallelShortCircuitReadUnCached
          org.apache.hadoop.net.TestNetworkTopology
          org.apache.hadoop.hdfs.TestPersistBlocks
          org.apache.hadoop.hdfs.TestRenameWhileOpen
          org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
          org.apache.hadoop.security.TestRefreshUserMappings
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractOpen
          org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
          org.apache.hadoop.fs.TestFcHdfsPermission
          org.apache.hadoop.hdfs.TestClose
          org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs
          org.apache.hadoop.hdfs.TestLeaseRecovery2
          org.apache.hadoop.hdfs.TestSnapshotCommands
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractMkdir
          org.apache.hadoop.hdfs.TestDatanodeBlockScanner
          org.apache.hadoop.hdfs.TestBalancerBandwidth
          org.apache.hadoop.hdfs.TestDFSFinalize
          org.apache.hadoop.hdfs.TestMiniDFSCluster
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.fs.TestUrlStreamHandler
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel
          org.apache.hadoop.fs.TestSymlinkHdfsFileSystem
          org.apache.hadoop.hdfs.TestListFilesInDFS
          org.apache.hadoop.hdfs.web.TestWebHdfsTokens
          org.apache.hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
          org.apache.hadoop.hdfs.TestDFSRename
          org.apache.hadoop.fs.viewfs.TestViewFsAtHdfsRoot
          org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA
          org.apache.hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
          org.apache.hadoop.hdfs.TestDataTransferProtocol
          org.apache.hadoop.hdfs.TestQuota
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractDelete
          org.apache.hadoop.hdfs.TestMissingBlocksAlert
          org.apache.hadoop.fs.TestGlobPaths
          org.apache.hadoop.hdfs.TestFSOutputSummer
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractConcat
          org.apache.hadoop.fs.TestEnhancedByteBufferAccess
          org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
          org.apache.hadoop.hdfs.TestMultiThreadedHflush
          org.apache.hadoop.hdfs.TestEncryptionZones
          org.apache.hadoop.hdfs.TestConnCache
          org.apache.hadoop.hdfs.TestRead
          org.apache.hadoop.hdfs.TestSetTimes
          org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
          org.apache.hadoop.hdfs.TestDFSOutputStream
          org.apache.hadoop.hdfs.TestIsMethodSupported
          org.apache.hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter
          org.apache.hadoop.fs.TestFcHdfsSetUMask
          org.apache.hadoop.hdfs.TestFsShellPermission
          org.apache.hadoop.tracing.TestTracing
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRename
          org.apache.hadoop.hdfs.TestFetchImage
          org.apache.hadoop.cli.TestXAttrCLI
          org.apache.hadoop.hdfs.TestFileAppend
          org.apache.hadoop.hdfs.TestLocalDFS
          org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
          org.apache.hadoop.hdfs.TestHdfsAdmin
          org.apache.hadoop.hdfs.TestDFSMkdirs
          org.apache.hadoop.fs.TestSymlinkHdfsFileContext
          org.apache.hadoop.hdfs.TestDatanodeReport
          org.apache.hadoop.hdfs.TestFileStatus
          org.apache.hadoop.hdfs.TestHDFSTrash
          org.apache.hadoop.hdfs.TestRollingUpgradeRollback
          org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
          org.apache.hadoop.hdfs.TestLargeBlock
          org.apache.hadoop.TestRefreshCallQueue
          org.apache.hadoop.hdfs.TestClientReportBadBlock
          org.apache.hadoop.hdfs.TestSetrepDecreasing
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.fs.TestResolveHdfsSymlink
          org.apache.hadoop.fs.shell.TestHdfsTextCommand
          org.apache.hadoop.cli.TestAclCLI
          org.apache.hadoop.hdfs.TestBlocksScheduledCounter
          org.apache.hadoop.tools.TestJMXGet
          org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          org.apache.hadoop.fs.TestFcHdfsCreateMkdir
          org.apache.hadoop.cli.TestHDFSCLI
          org.apache.hadoop.hdfs.tools.TestGetGroups
          org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs
          org.apache.hadoop.fs.TestHDFSFileContextMainOperations
          org.apache.hadoop.hdfs.TestFileLengthOnClusterRestart
          org.apache.hadoop.hdfs.TestListFilesInFileContext
          org.apache.hadoop.hdfs.TestCrcCorruption
          org.apache.hadoop.hdfs.TestReadWhileWriting
          org.apache.hadoop.hdfs.TestFileAppend3
          org.apache.hadoop.hdfs.TestBlockReaderFactory
          org.apache.hadoop.hdfs.TestReplication
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractCreate
          org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
          org.apache.hadoop.hdfs.web.TestHttpsFileSystem
          org.apache.hadoop.hdfs.qjournal.TestNNWithQJM
          org.apache.hadoop.hdfs.TestSetrepIncreasing
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractAppend
          org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
          org.apache.hadoop.hdfs.web.TestWebHDFSAcl
          org.apache.hadoop.hdfs.TestFSInputChecker
          org.apache.hadoop.fs.permission.TestStickyBit
          org.apache.hadoop.fs.viewfs.TestViewFsDefaultValue
          org.apache.hadoop.fs.viewfs.TestViewFsHdfs
          org.apache.hadoop.hdfs.TestHDFSServerPorts
          org.apache.hadoop.cli.TestCryptoAdminCLI
          org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4618//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4618//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665713/HADOOP-11032.3.patch against trunk revision 258c7d0. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.hdfs.TestHDFSFileSystemContract org.apache.hadoop.hdfs.TestEncryptedTransfer org.apache.hadoop.hdfs.TestRollingUpgrade org.apache.hadoop.hdfs.web.TestWebHDFSForHA org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls org.apache.hadoop.TestGenericRefresh org.apache.hadoop.fs.contract.hdfs.TestHDFSContractSeek org.apache.hadoop.hdfs.TestPread org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs org.apache.hadoop.hdfs.crypto.TestHdfsCryptoStreams org.apache.hadoop.hdfs.TestWriteBlockGetsBlockLengthHint org.apache.hadoop.fs.TestSymlinkHdfsDisable org.apache.hadoop.hdfs.TestDecommission org.apache.hadoop.hdfs.TestDFSRemove org.apache.hadoop.cli.TestCacheAdminCLI org.apache.hadoop.fs.loadGenerator.TestLoadGenerator org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.security.TestPermission org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.web.TestWebHDFSXAttr org.apache.hadoop.hdfs.TestModTime org.apache.hadoop.hdfs.TestBlockReaderLocalLegacy org.apache.hadoop.hdfs.web.TestWebHDFS org.apache.hadoop.hdfs.TestDatanodeConfig org.apache.hadoop.hdfs.TestDFSUpgrade org.apache.hadoop.hdfs.TestParallelRead org.apache.hadoop.security.TestPermissionSymlinks org.apache.hadoop.hdfs.tools.TestDFSHAAdminMiniCluster org.apache.hadoop.fs.viewfs.TestViewFsWithAcls org.apache.hadoop.hdfs.TestParallelShortCircuitReadUnCached org.apache.hadoop.net.TestNetworkTopology org.apache.hadoop.hdfs.TestPersistBlocks org.apache.hadoop.hdfs.TestRenameWhileOpen org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage org.apache.hadoop.security.TestRefreshUserMappings org.apache.hadoop.fs.contract.hdfs.TestHDFSContractOpen org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs org.apache.hadoop.fs.TestFcHdfsPermission org.apache.hadoop.hdfs.TestClose org.apache.hadoop.fs.viewfs.TestViewFsWithXAttrs org.apache.hadoop.hdfs.TestLeaseRecovery2 org.apache.hadoop.hdfs.TestSnapshotCommands org.apache.hadoop.fs.contract.hdfs.TestHDFSContractMkdir org.apache.hadoop.hdfs.TestDatanodeBlockScanner org.apache.hadoop.hdfs.TestBalancerBandwidth org.apache.hadoop.hdfs.TestDFSFinalize org.apache.hadoop.hdfs.TestMiniDFSCluster org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.fs.TestUrlStreamHandler org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel org.apache.hadoop.fs.TestSymlinkHdfsFileSystem org.apache.hadoop.hdfs.TestListFilesInDFS org.apache.hadoop.hdfs.web.TestWebHdfsTokens org.apache.hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot org.apache.hadoop.hdfs.TestDFSRename org.apache.hadoop.fs.viewfs.TestViewFsAtHdfsRoot org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA org.apache.hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer org.apache.hadoop.hdfs.TestDataTransferProtocol org.apache.hadoop.hdfs.TestQuota org.apache.hadoop.fs.contract.hdfs.TestHDFSContractDelete org.apache.hadoop.hdfs.TestMissingBlocksAlert org.apache.hadoop.fs.TestGlobPaths org.apache.hadoop.hdfs.TestFSOutputSummer org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.fs.contract.hdfs.TestHDFSContractConcat org.apache.hadoop.fs.TestEnhancedByteBufferAccess org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract org.apache.hadoop.hdfs.TestMultiThreadedHflush org.apache.hadoop.hdfs.TestEncryptionZones org.apache.hadoop.hdfs.TestConnCache org.apache.hadoop.hdfs.TestRead org.apache.hadoop.hdfs.TestSetTimes org.apache.hadoop.fs.viewfs.TestViewFileSystemWithXAttrs org.apache.hadoop.hdfs.TestDFSOutputStream org.apache.hadoop.hdfs.TestIsMethodSupported org.apache.hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter org.apache.hadoop.fs.TestFcHdfsSetUMask org.apache.hadoop.hdfs.TestFsShellPermission org.apache.hadoop.tracing.TestTracing org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRename org.apache.hadoop.hdfs.TestFetchImage org.apache.hadoop.cli.TestXAttrCLI org.apache.hadoop.hdfs.TestFileAppend org.apache.hadoop.hdfs.TestLocalDFS org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl org.apache.hadoop.hdfs.TestHdfsAdmin org.apache.hadoop.hdfs.TestDFSMkdirs org.apache.hadoop.fs.TestSymlinkHdfsFileContext org.apache.hadoop.hdfs.TestDatanodeReport org.apache.hadoop.hdfs.TestFileStatus org.apache.hadoop.hdfs.TestHDFSTrash org.apache.hadoop.hdfs.TestRollingUpgradeRollback org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.TestRefreshCallQueue org.apache.hadoop.hdfs.TestClientReportBadBlock org.apache.hadoop.hdfs.TestSetrepDecreasing org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.fs.TestResolveHdfsSymlink org.apache.hadoop.fs.shell.TestHdfsTextCommand org.apache.hadoop.cli.TestAclCLI org.apache.hadoop.hdfs.TestBlocksScheduledCounter org.apache.hadoop.tools.TestJMXGet org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.fs.TestFcHdfsCreateMkdir org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.tools.TestGetGroups org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs org.apache.hadoop.fs.TestHDFSFileContextMainOperations org.apache.hadoop.hdfs.TestFileLengthOnClusterRestart org.apache.hadoop.hdfs.TestListFilesInFileContext org.apache.hadoop.hdfs.TestCrcCorruption org.apache.hadoop.hdfs.TestReadWhileWriting org.apache.hadoop.hdfs.TestFileAppend3 org.apache.hadoop.hdfs.TestBlockReaderFactory org.apache.hadoop.hdfs.TestReplication org.apache.hadoop.fs.contract.hdfs.TestHDFSContractCreate org.apache.hadoop.hdfs.TestDFSUpgradeFromImage org.apache.hadoop.hdfs.web.TestHttpsFileSystem org.apache.hadoop.hdfs.qjournal.TestNNWithQJM org.apache.hadoop.hdfs.TestSetrepIncreasing org.apache.hadoop.fs.contract.hdfs.TestHDFSContractAppend org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes org.apache.hadoop.hdfs.web.TestWebHDFSAcl org.apache.hadoop.hdfs.TestFSInputChecker org.apache.hadoop.fs.permission.TestStickyBit org.apache.hadoop.fs.viewfs.TestViewFsDefaultValue org.apache.hadoop.fs.viewfs.TestViewFsHdfs org.apache.hadoop.hdfs.TestHDFSServerPorts org.apache.hadoop.cli.TestCryptoAdminCLI org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4618//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4618//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          This test failures looks not related to our patch. Anyway, I'll try to attach a same patch again later.

          java.lang.NoClassDefFoundError: org/apache/hadoop/tracing/SpanReceiverHost
          	at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
          	at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
          	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
          	at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:592)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:761)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:745)
          	at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1433)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1104)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:975)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:804)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:465)
          	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:424)
          	at org.apache.hadoop.hdfs.TestSetTimes.testTimes(TestSetTimes.java:100)
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - This test failures looks not related to our patch. Anyway, I'll try to attach a same patch again later. java.lang.NoClassDefFoundError: org/apache/hadoop/tracing/SpanReceiverHost at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang. ClassLoader .loadClass( ClassLoader .java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang. ClassLoader .loadClass( ClassLoader .java:247) at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:592) at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:761) at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:745) at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1433) at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1104) at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:975) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:804) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:465) at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:424) at org.apache.hadoop.hdfs.TestSetTimes.testTimes(TestSetTimes.java:100)
          Hide
          gsteelman Gary Steelman added a comment -

          Thanks for touching the patch Tsuyoshi Ozawa.

          First, wow, that is a lot of failures. Any idea if the build scripts changed and that's the reason we can't find SpanReceiverHost? Looks like every test failure is because of that.

          Second, I think a silent pass or a Log.warn() statement would suffice for StopWatch.stop() twice in a row. Throwing an exception seems overkill to me. Do you think we should file a Jira to do this?

          And finally, if we remove the patch 3 attachment and re-upload it as patch 3 again, will Jenkins will build with patch 3 again?

          Show
          gsteelman Gary Steelman added a comment - Thanks for touching the patch Tsuyoshi Ozawa . First, wow, that is a lot of failures. Any idea if the build scripts changed and that's the reason we can't find SpanReceiverHost? Looks like every test failure is because of that. Second, I think a silent pass or a Log.warn() statement would suffice for StopWatch.stop() twice in a row. Throwing an exception seems overkill to me. Do you think we should file a Jira to do this? And finally, if we remove the patch 3 attachment and re-upload it as patch 3 again, will Jenkins will build with patch 3 again?
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Gary Steelman, thanks for your suggestions.

          Any idea if the build scripts changed and that's the reason we can't find SpanReceiverHost?

          I think HDFS-7001 is addressing the problem.

          Second, I think a silent pass or a Log.warn() statement would suffice for StopWatch.stop() twice in a row.

          Do you mean should we add wrapper class of Stopwatch to handle them? It also can be overkill. I think we should it's enough to use Stopwatch class correctly.

          And finally, if we remove the patch 3 attachment and re-upload it as patch 3 again, will Jenkins will build with patch 3 again?

          Yes, Jenkins will

          Show
          ozawa Tsuyoshi Ozawa added a comment - Gary Steelman , thanks for your suggestions. Any idea if the build scripts changed and that's the reason we can't find SpanReceiverHost? I think HDFS-7001 is addressing the problem. Second, I think a silent pass or a Log.warn() statement would suffice for StopWatch.stop() twice in a row. Do you mean should we add wrapper class of Stopwatch to handle them? It also can be overkill. I think we should it's enough to use Stopwatch class correctly. And finally, if we remove the patch 3 attachment and re-upload it as patch 3 again, will Jenkins will build with patch 3 again? Yes, Jenkins will
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12666820/HADOOP-11032.3.patch
          against trunk revision 45efc96.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.ha.TestZKFailoverControllerStress
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4658//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4658//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12666820/HADOOP-11032.3.patch against trunk revision 45efc96. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.ha.TestZKFailoverControllerStress org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4658//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4658//console This message is automatically generated.
          Hide
          gsteelman Gary Steelman added a comment -

          Thanks Tsuyoshi Ozawa. The test failures don't appear to be related to this patch.

          For fixing the exception thrown when StopWatch.stop() is called twice consecutively, ideally the fix is to simply not call stop() twice consecutively. I meant, however, we could submit a patch to the commons project to change the behavior of stop() to Log.warn("StopWatch is already in stopped state"); or be a no-op instead of throwing an Exception.

          Show
          gsteelman Gary Steelman added a comment - Thanks Tsuyoshi Ozawa . The test failures don't appear to be related to this patch. For fixing the exception thrown when StopWatch.stop() is called twice consecutively, ideally the fix is to simply not call stop() twice consecutively. I meant, however, we could submit a patch to the commons project to change the behavior of stop() to Log.warn("StopWatch is already in stopped state"); or be a no-op instead of throwing an Exception.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668853/HADOOP-11032.3.patch
          against trunk revision 88e329f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.ha.TestZKFailoverControllerStress
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel
          org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4726//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4726//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668853/HADOOP-11032.3.patch against trunk revision 88e329f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.ha.TestZKFailoverControllerStress org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4726//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4726//console This message is automatically generated.
          Hide
          gsteelman Gary Steelman added a comment -

          Again these test failures don't appear to be related to the patch.

          Show
          gsteelman Gary Steelman added a comment - Again these test failures don't appear to be related to the patch.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1.

          I note that TestJournalNode drops a couple more imports —as everything builds I'm assuming they were unused

          Show
          stevel@apache.org Steve Loughran added a comment - +1. I note that TestJournalNode drops a couple more imports —as everything builds I'm assuming they were unused
          Hide
          stevel@apache.org Steve Loughran added a comment -

          resubmitting patch to see what tests are failing.

          Show
          stevel@apache.org Steve Loughran added a comment - resubmitting patch to see what tests are failing.
          Hide
          gsteelman Gary Steelman added a comment -

          Steve Loughran it looks like you forgot to reattach the patch . I've reattached it. We'll see if the build comes back clean this time.

          Show
          gsteelman Gary Steelman added a comment - Steve Loughran it looks like you forgot to reattach the patch . I've reattached it. We'll see if the build comes back clean this time.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Thanks for reattaching a patch, Gary and Steve.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Thanks for reattaching a patch, Gary and Steve.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12671939/HADOOP-11032.3.patch
          against trunk revision 0577eb3.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4835//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4835//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4835//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671939/HADOOP-11032.3.patch against trunk revision 0577eb3. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.hdfs.server.namenode.TestCheckpoint org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel -1 contrib tests . The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4835//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4835//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4835//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          On my local, I cannot I'll see the warnings. I'll check why this happens...

          Show
          ozawa Tsuyoshi Ozawa added a comment - On my local, I cannot I'll see the warnings. I'll check why this happens...
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          s/I'll//

          Show
          ozawa Tsuyoshi Ozawa added a comment - s/I'll//
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Ran tests and findbugs locally, but I cannot reproduce the faliures. Attaching same patch again.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Ran tests and findbugs locally, but I cannot reproduce the faliures. Attaching same patch again.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12672398/HADOOP-11032.3.patch
          against trunk revision 875aa79.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core:

          org.apache.hadoop.hdfs.server.namenode.TestAuditLogs

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//artifact/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12672398/HADOOP-11032.3.patch against trunk revision 875aa79. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: org.apache.hadoop.hdfs.server.namenode.TestAuditLogs -1 contrib tests . The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4846//console This message is automatically generated.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for the patch Tsuyoshi Ozawa!

          One high level comment: although the APIs are similar, guava's Stopwatch is based on System.nanoTime(), whereas Apache Common's StopWatch is using System.currentTimeMillis(). The resolution of the latter is not terribly great, and I do worry about lost precision here, especially ones like in Journal where it appears to be looking for microseconds. So I'm basically -1 on using Apache StopWatch.

          How about introducing a small utility class in hadoop itself to handle this? It can really be a very very simple class, and may be worth it if we want to avoid using guava for simple things like this.

          Show
          sjlee0 Sangjin Lee added a comment - Thanks for the patch Tsuyoshi Ozawa ! One high level comment: although the APIs are similar, guava's Stopwatch is based on System.nanoTime(), whereas Apache Common's StopWatch is using System.currentTimeMillis(). The resolution of the latter is not terribly great, and I do worry about lost precision here, especially ones like in Journal where it appears to be looking for microseconds. So I'm basically -1 on using Apache StopWatch. How about introducing a small utility class in hadoop itself to handle this? It can really be a very very simple class, and may be worth it if we want to avoid using guava for simple things like this.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12672398/HADOOP-11032.3.patch
          against trunk revision 3b173d9.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5296//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12672398/HADOOP-11032.3.patch against trunk revision 3b173d9. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5296//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Sangjin Lee Thanks for your comment. I was also thinking that it's better to have utility class based on old Guava. I'm updating it.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Sangjin Lee Thanks for your comment. I was also thinking that it's better to have utility class based on old Guava. I'm updating it.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          ..nanoTime is less brittle to clock drift/regression on VMs.

          with our own class we could also go for a 1:1 mapping on Guava, e.g. make close() idempotent. In fact, make it Closeable for the new try/catch stuff.

          I'd recommend making the now() operation overiddeable in subclasses for ease of testing; the test class would increment by 1 each call or similar
          It's a shame to have to reimplement stuff, but sometimes its easier that way.

          Show
          stevel@apache.org Steve Loughran added a comment - ..nanoTime is less brittle to clock drift/regression on VMs. with our own class we could also go for a 1:1 mapping on Guava, e.g. make close() idempotent. In fact, make it Closeable for the new try/catch stuff. I'd recommend making the now() operation overiddeable in subclasses for ease of testing; the test class would increment by 1 each call or similar It's a shame to have to reimplement stuff, but sometimes its easier that way.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Steve Loughran Make sense. Implemented simplified stopwatch for nanoTime which has a overridable now() method.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Steve Loughran Make sense. Implemented simplified stopwatch for nanoTime which has a overridable now() method.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688298/HADOOP-11032.4.patch
          against trunk revision 6635ccd.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5314//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688298/HADOOP-11032.4.patch against trunk revision 6635ccd. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5314//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Rebasing a patch on trunk.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Rebasing a patch on trunk.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688301/HADOOP-11032.5.patch
          against trunk revision 6635ccd.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask:

          org.apache.hadoop.hdfs.TestRollingUpgrade
          org.apache.hadoop.hdfs.TestDecommission
          org.apache.hadoop.fs.TestSymlinkHdfsFileContext
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688301/HADOOP-11032.5.patch against trunk revision 6635ccd. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask: org.apache.hadoop.hdfs.TestRollingUpgrade org.apache.hadoop.hdfs.TestDecommission org.apache.hadoop.fs.TestSymlinkHdfsFileContext org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5315//console This message is automatically generated.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for the patch Tsuyoshi Ozawa! Some comments:

          mapred/FileInputFormat.java

          • l.246: now() is in nanosecond; you should call now(TimeUnit.MILLISECONDS)

          StopWatch.java

          • l.51: why another call of System.nanoTime()? Perhaps you forgot to remove it?
          • l.60: I would check the state before calling System.nanoTime()
          • it would be clearer to rename members to startNanos and currentElapsedNanos to be clear that's the unit...
          • l.45 I would say "this instance of StopWatch" in the javadoc to be clear we're not returning an arbitrary instance; the same for all methods that return this
          • AutoCloseable is a class introduced in Java 1.7. So is the restriction of not using Java 1.7 classes lifted?
          • nit: can we not use guava's Preconditions? It's a simple check of the state, and while we're at reducing the usage of guava here, relying on Preconditions seems going against that grain.

          Journal.java

          • l.382: it might be good to get the millis once and reuse it

          JvmPauseMonitor.java

          • the StopWatch import is unnecessary as it's in the same package

          TestChunkedArrayList.java

          • the StopWatch import is unnecessary as it's in the same package

          TestDataChecksum.java

          • the StopWatch import is unnecessary as it's in the same package
          Show
          sjlee0 Sangjin Lee added a comment - Thanks for the patch Tsuyoshi Ozawa ! Some comments: mapred/FileInputFormat.java l.246: now() is in nanosecond; you should call now(TimeUnit.MILLISECONDS) StopWatch.java l.51: why another call of System.nanoTime()? Perhaps you forgot to remove it? l.60: I would check the state before calling System.nanoTime() it would be clearer to rename members to startNanos and currentElapsedNanos to be clear that's the unit... l.45 I would say "this instance of StopWatch" in the javadoc to be clear we're not returning an arbitrary instance; the same for all methods that return this AutoCloseable is a class introduced in Java 1.7. So is the restriction of not using Java 1.7 classes lifted? nit: can we not use guava's Preconditions? It's a simple check of the state, and while we're at reducing the usage of guava here, relying on Preconditions seems going against that grain. Journal.java l.382: it might be good to get the millis once and reuse it JvmPauseMonitor.java the StopWatch import is unnecessary as it's in the same package TestChunkedArrayList.java the StopWatch import is unnecessary as it's in the same package TestDataChecksum.java the StopWatch import is unnecessary as it's in the same package
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Thanks for your review, Sangjin Lee! Uploading v6 patch to address your comments.

          StopWatch.java

          • Removing needless calls
          • Checking state before calling System.nanoTime()
          • Renaming members to include the time unit "nano"
          • Saying "this instance of StopWatch" in javadoc
          • Using Closesable instead of AutoCloseable for JDK6 - I know that we're only use JDK7+, but I don't find any reason to use AutoCloseable.
          • Removing usages of Preconditions.checkState(). Maybe we can have these kind of simple utility by ourselves.

          Other classes

          • Changing mapred/FileInputFormat to call now(TimeUnit.MILLISECONDS)
          • Removing needless packages.
          Show
          ozawa Tsuyoshi Ozawa added a comment - Thanks for your review, Sangjin Lee ! Uploading v6 patch to address your comments. StopWatch.java Removing needless calls Checking state before calling System.nanoTime() Renaming members to include the time unit "nano" Saying "this instance of StopWatch" in javadoc Using Closesable instead of AutoCloseable for JDK6 - I know that we're only use JDK7+, but I don't find any reason to use AutoCloseable. Removing usages of Preconditions.checkState(). Maybe we can have these kind of simple utility by ourselves. Other classes Changing mapred/FileInputFormat to call now(TimeUnit.MILLISECONDS) Removing needless packages.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for the update. It looks good to me except for just one thing. Currently in Journal.java you have

              long nanoSeconds = sw.now();
              metrics.addSync(
                  TimeUnit.MICROSECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS));
              if (TimeUnit.MILLISECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS)
                  > WARN_SYNC_MILLIS_THRESHOLD) {
                 LOG.warn("Sync of transaction range " + firstTxnId + "-" + lastTxnId +
                         " took " + sw.now(TimeUnit.MILLISECONDS) + "ms");
          

          I think this could be improved slightly to shave off a few more cycles:

              long nanoSeconds = sw.now();
              metrics.addSync(
                  TimeUnit.MICROSECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS));
              long millis = TimeUnit.MILLISECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS);
              if (millis > WARN_SYNC_MILLIS_THRESHOLD) {
                 LOG.warn("Sync of transaction range " + firstTxnId + "-" + lastTxnId +
                         " took " + millis + "ms");
          

          or

              long micros = sw.now(TimeUnit.MICROSECONDS);
              metrics.addSync(micros);
              long millis = TimeUnit.MILLISECONDS.convert(micros, TimeUnit.MICROSECONDS);
              if (millis > WARN_SYNC_MILLIS_THRESHOLD) {
                 LOG.warn("Sync of transaction range " + firstTxnId + "-" + lastTxnId +
                         " took " + millis + "ms");
          
          Show
          sjlee0 Sangjin Lee added a comment - Thanks for the update. It looks good to me except for just one thing. Currently in Journal.java you have long nanoSeconds = sw.now(); metrics.addSync( TimeUnit.MICROSECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS)); if (TimeUnit.MILLISECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS) > WARN_SYNC_MILLIS_THRESHOLD) { LOG.warn( "Sync of transaction range " + firstTxnId + "-" + lastTxnId + " took " + sw.now(TimeUnit.MILLISECONDS) + "ms" ); I think this could be improved slightly to shave off a few more cycles: long nanoSeconds = sw.now(); metrics.addSync( TimeUnit.MICROSECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS)); long millis = TimeUnit.MILLISECONDS.convert(nanoSeconds, TimeUnit.NANOSECONDS); if (millis > WARN_SYNC_MILLIS_THRESHOLD) { LOG.warn( "Sync of transaction range " + firstTxnId + "-" + lastTxnId + " took " + millis + "ms" ); or long micros = sw.now(TimeUnit.MICROSECONDS); metrics.addSync(micros); long millis = TimeUnit.MILLISECONDS.convert(micros, TimeUnit.MICROSECONDS); if (millis > WARN_SYNC_MILLIS_THRESHOLD) { LOG.warn( "Sync of transaction range " + firstTxnId + "-" + lastTxnId + " took " + millis + "ms" );
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Good catch. Uploading v7 to fix the points.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Good catch. Uploading v7 to fix the points.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688486/HADOOP-11032.6.patch
          against trunk revision 808cba3.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask:

          org.apache.hadoop.util.TestChunkedArrayList
          org.apache.hadoop.util.TestDataChecksum
          org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat
          org.apache.hadoop.mapred.TestFileInputFormat
          org.apache.hadoop.mapred.nativetask.combinertest.OldAPICombinerTest
          org.apache.hadoop.mapred.nativetask.combinertest.CombinerTest
          org.apache.hadoop.mapred.nativetask.combinertest.LargeKVCombinerTest
          org.apache.hadoop.mapred.nativetask.kvtest.KVTest
          org.apache.hadoop.mapred.nativetask.compresstest.CompressTest
          org.apache.hadoop.mapred.nativetask.nonsorttest.NonSortTest
          org.apache.hadoop.mapred.nativetask.kvtest.LargeKVTest
          org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager
          org.apache.hadoop.hdfs.TestRollingUpgrade
          org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream
          org.apache.hadoop.hdfs.qjournal.server.TestJournalNode
          org.apache.hadoop.hdfs.TestRollingUpgradeDowngrade
          org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
          org.apache.hadoop.hdfs.qjournal.server.TestJournal
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel
          org.apache.hadoop.hdfs.TestMultiThreadedHflush
          org.apache.hadoop.fs.TestSymlinkHdfsFileContext
          org.apache.hadoop.hdfs.TestRollingUpgradeRollback
          org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM
          org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          org.apache.hadoop.hdfs.qjournal.TestNNWithQJM
          org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688486/HADOOP-11032.6.patch against trunk revision 808cba3. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask: org.apache.hadoop.util.TestChunkedArrayList org.apache.hadoop.util.TestDataChecksum org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat org.apache.hadoop.mapred.TestFileInputFormat org.apache.hadoop.mapred.nativetask.combinertest.OldAPICombinerTest org.apache.hadoop.mapred.nativetask.combinertest.CombinerTest org.apache.hadoop.mapred.nativetask.combinertest.LargeKVCombinerTest org.apache.hadoop.mapred.nativetask.kvtest.KVTest org.apache.hadoop.mapred.nativetask.compresstest.CompressTest org.apache.hadoop.mapred.nativetask.nonsorttest.NonSortTest org.apache.hadoop.mapred.nativetask.kvtest.LargeKVTest org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager org.apache.hadoop.hdfs.TestRollingUpgrade org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream org.apache.hadoop.hdfs.qjournal.server.TestJournalNode org.apache.hadoop.hdfs.TestRollingUpgradeDowngrade org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM org.apache.hadoop.hdfs.qjournal.server.TestJournal org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel org.apache.hadoop.hdfs.TestMultiThreadedHflush org.apache.hadoop.fs.TestSymlinkHdfsFileContext org.apache.hadoop.hdfs.TestRollingUpgradeRollback org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA org.apache.hadoop.hdfs.qjournal.TestNNWithQJM org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5323//console This message is automatically generated.
          Hide
          sjlee0 Sangjin Lee added a comment -

          I missed something so obvious. The checks in start() and stop() for isStarted are reversed. That should be fixed.

          Show
          sjlee0 Sangjin Lee added a comment - I missed something so obvious. The checks in start() and stop() for isStarted are reversed. That should be fixed.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Sangjin Lee Oops, my bad. I fixed the bug and added TestStopWatch.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Sangjin Lee Oops, my bad. I fixed the bug and added TestStopWatch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688497/HADOOP-11032.7.patch
          against trunk revision c1f857b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask:

          org.apache.hadoop.util.TestDataChecksum
          org.apache.hadoop.util.TestChunkedArrayList
          org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat
          org.apache.hadoop.mapred.TestFileInputFormat
          org.apache.hadoop.mapred.nativetask.compresstest.CompressTest
          org.apache.hadoop.mapred.nativetask.combinertest.LargeKVCombinerTest
          org.apache.hadoop.mapred.nativetask.kvtest.KVTest
          org.apache.hadoop.mapred.nativetask.kvtest.LargeKVTest
          org.apache.hadoop.mapred.nativetask.combinertest.OldAPICombinerTest
          org.apache.hadoop.mapred.nativetask.combinertest.CombinerTest
          org.apache.hadoop.mapred.nativetask.nonsorttest.NonSortTest
          org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager
          org.apache.hadoop.hdfs.qjournal.server.TestJournal
          org.apache.hadoop.hdfs.qjournal.server.TestJournalNode
          org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM
          org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          org.apache.hadoop.hdfs.qjournal.TestNNWithQJM
          org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel
          org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults
          org.apache.hadoop.hdfs.TestRollingUpgrade
          org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
          org.apache.hadoop.hdfs.TestRollingUpgradeRollback
          org.apache.hadoop.hdfs.TestMultiThreadedHflush
          org.apache.hadoop.hdfs.TestRollingUpgradeDowngrade
          org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream
          org.apache.hadoop.fs.TestSymlinkHdfsFileContext

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688497/HADOOP-11032.7.patch against trunk revision c1f857b. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 5 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask: org.apache.hadoop.util.TestDataChecksum org.apache.hadoop.util.TestChunkedArrayList org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat org.apache.hadoop.mapred.TestFileInputFormat org.apache.hadoop.mapred.nativetask.compresstest.CompressTest org.apache.hadoop.mapred.nativetask.combinertest.LargeKVCombinerTest org.apache.hadoop.mapred.nativetask.kvtest.KVTest org.apache.hadoop.mapred.nativetask.kvtest.LargeKVTest org.apache.hadoop.mapred.nativetask.combinertest.OldAPICombinerTest org.apache.hadoop.mapred.nativetask.combinertest.CombinerTest org.apache.hadoop.mapred.nativetask.nonsorttest.NonSortTest org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager org.apache.hadoop.hdfs.qjournal.server.TestJournal org.apache.hadoop.hdfs.qjournal.server.TestJournalNode org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA org.apache.hadoop.hdfs.qjournal.TestNNWithQJM org.apache.hadoop.hdfs.qjournal.client.TestIPCLoggerChannel org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults org.apache.hadoop.hdfs.TestRollingUpgrade org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM org.apache.hadoop.hdfs.TestRollingUpgradeRollback org.apache.hadoop.hdfs.TestMultiThreadedHflush org.apache.hadoop.hdfs.TestRollingUpgradeDowngrade org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream org.apache.hadoop.fs.TestSymlinkHdfsFileContext Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5324//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          This failure is against old one. Let's wait for the result against new patch.

          Show
          ozawa Tsuyoshi Ozawa added a comment - This failure is against old one. Let's wait for the result against new patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688504/HADOOP-11032.8.patch
          against trunk revision c1f857b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask:

          org.apache.hadoop.fs.TestSymlinkHdfsFileContext

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688504/HADOOP-11032.8.patch against trunk revision c1f857b. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 16 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask: org.apache.hadoop.fs.TestSymlinkHdfsFileContext Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5325//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          It's ready for review. Sangjin Lee, could you take a look?

          Show
          ozawa Tsuyoshi Ozawa added a comment - It's ready for review. Sangjin Lee , could you take a look?
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for adding the unit test for it. It looks good to me!

          Show
          sjlee0 Sangjin Lee added a comment - Thanks for adding the unit test for it. It looks good to me!
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for adding the unit test for it. It looks good to me!

          Show
          sjlee0 Sangjin Lee added a comment - Thanks for adding the unit test for it. It looks good to me!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Looks good to me, +1. The findbug warnings and test failure are not related to the patch.
          We should edit the title because the patch does not use Apache StopWatch.

          Show
          ajisakaa Akira Ajisaka added a comment - Looks good to me, +1. The findbug warnings and test failure are not related to the patch. We should edit the title because the patch does not use Apache StopWatch.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Thanks for your review, Akira. Resubmitting the patch and pending for Jenkins.

          Steve Loughran, please let me know if you have any concerns about this patch.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Thanks for your review, Akira. Resubmitting the patch and pending for Jenkins. Steve Loughran , please let me know if you have any concerns about this patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690556/HADOOP-11032.8.patch
          against trunk revision 788ee35.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5376//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5376//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5376//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690556/HADOOP-11032.8.patch against trunk revision 788ee35. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5376//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5376//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5376//console This message is automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committing this to trunk and branch-2.

          Thanks Gary Steelman for reporting and reviews and thanks Sangjin Lee, Steve Loughran, Akira Ajisaka for your reviews.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committing this to trunk and branch-2. Thanks Gary Steelman for reporting and reviews and thanks Sangjin Lee , Steve Loughran , Akira Ajisaka for your reviews.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6829 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6829/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6829 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6829/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #67 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/67/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #67 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/67/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-mapreduce-project/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #801 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/801/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #801 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/801/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1999 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1999/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1999 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1999/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #64 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/64/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #64 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/64/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #68 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/68/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #68 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/68/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2018 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2018/)
          HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2018 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2018/ ) HADOOP-11032 . Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa) (ozawa: rev a6ed4894b518351bf1b3290e725a475570a21296) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StopWatch.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestChunkedArrayList.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDataChecksum.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStopWatch.java hadoop-mapreduce-project/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
          Hide
          gsteelman Gary Steelman added a comment -

          You're welcome Tsuyoshi Ozawa and thank you for seeing this through to the end!

          Show
          gsteelman Gary Steelman added a comment - You're welcome Tsuyoshi Ozawa and thank you for seeing this through to the end!

            People

            • Assignee:
              ozawa Tsuyoshi Ozawa
              Reporter:
              gsteelman Gary Steelman
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development