[HADOOP-10998] Fix bash tab completion code to work

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: scripts

Environment

Hadoop 2.0.0-cdh4.2.1

• Assignee: Jim Hester
• Reporter: Jim Hester
• Created: 22/Aug/14 13:26
• Updated: 01/Dec/14 03:11
• Resolved: 22/Aug/14 18:22

Description

The included version of bash completion has not been updated in almost two years and does not work correctly with more recent versions of Hadoop.

The command substitutions in the script were using backticks, which were interpolating variables before they were executed and breaking the script. In particular the awk commands were breaking due to this interpolation.

The attached patch changes the backticks to $(command) style for command substitution and updates the script to work properly with newer versions of hadoop.

I tested the script using zsh 5.0.5, zsh 4.3.10]}, {{bash-4.1.2 and bash-3.2. Hadoop versions tested were cloudera version 2.0.0-cdh4.2.1 and briefly Apache 2.5.0.

Issue Links

• duplicates: HADOOP-9959 Shell completion is broken
• duplicates: HADOOP-6310 bash completion doesn't quite work.
• relates to: HADOOP-3714 Bash tab completion support