Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: ipc
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      The rpc client does no bounds checking of server responses. In the case of communicating with an older and incompatible RPC, this may lead to OOM issues and leaking of resources.

      1. HADOOP-10940.1.patch
        24 kB
        Daryn Sharp
      2. HADOOP-10940.patch
        29 kB
        Daryn Sharp
      3. HADOOP-10940.patch
        29 kB
        Daryn Sharp
      4. HADOOP-10940.patch
        25 kB
        Daryn Sharp
      5. HADOOP-10940.patch
        25 kB
        Daryn Sharp
      6. HADOOP-10940.patch
        23 kB
        Daryn Sharp
      7. HADOOP-10940.trunk.1.patch
        24 kB
        Daryn Sharp
      8. HADOOP-10940.trunk.2.patch
        25 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          daryn Daryn Sharp added a comment -

          The problem causes invalid rpc responses to cause the client to go OOM. This is killing oozie servers when users try to use a 2.x client to 0.23. The same applies for 2.x to 1.x.

          Added a IpcStreams object to manage the rpc encoding/decoding. Response size must be > 0 and < data data length used by the rpc server. Request decoding is simpler and more efficient.

          If the first response has length -1, then it's assumed to be a pre-rpcv9 error response. Pre-rpcv9 responses began with the callId, not a length, and the callId for error was -1.

          This patch also fixes flushing issues. Namely the multiple-send before reading a response. This occurs in two cases:

          1. insecure: connection header+context+call
          2. secure: connection header+sasl negotiate

          W/o the fix to control flushing, unit tests to verify invalid rpc version always failed with broken pipe. When the server reads the connection header for an incompatible client, it sends an error response and immediately closes the socket. The client may still be in the process of sending multiple messages as listed above and cause a broken pipe.

          I believe the flushing issue may also solve the sporadic unit tests failing under windows about the remote end closing the connection.

          Show
          daryn Daryn Sharp added a comment - The problem causes invalid rpc responses to cause the client to go OOM. This is killing oozie servers when users try to use a 2.x client to 0.23. The same applies for 2.x to 1.x. Added a IpcStreams object to manage the rpc encoding/decoding. Response size must be > 0 and < data data length used by the rpc server. Request decoding is simpler and more efficient. If the first response has length -1, then it's assumed to be a pre-rpcv9 error response. Pre-rpcv9 responses began with the callId, not a length, and the callId for error was -1. This patch also fixes flushing issues. Namely the multiple-send before reading a response. This occurs in two cases: insecure: connection header+context+call secure: connection header+sasl negotiate W/o the fix to control flushing, unit tests to verify invalid rpc version always failed with broken pipe. When the server reads the connection header for an incompatible client, it sends an error response and immediately closes the socket. The client may still be in the process of sending multiple messages as listed above and cause a broken pipe. I believe the flushing issue may also solve the sporadic unit tests failing under windows about the remote end closing the connection.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12659990/HADOOP-10940.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ipc.TestRPCCallBenchmark
          org.apache.hadoop.net.TestNetUtils
          org.apache.hadoop.security.TestSecurityUtil
          org.apache.hadoop.ha.TestZKFailoverControllerStress
          org.apache.hadoop.ipc.TestRPC
          org.apache.hadoop.security.TestDoAsEffectiveUser
          org.apache.hadoop.conf.TestConfiguration
          org.apache.hadoop.ipc.TestIPC

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4434//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4434//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4434//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12659990/HADOOP-10940.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ipc.TestRPCCallBenchmark org.apache.hadoop.net.TestNetUtils org.apache.hadoop.security.TestSecurityUtil org.apache.hadoop.ha.TestZKFailoverControllerStress org.apache.hadoop.ipc.TestRPC org.apache.hadoop.security.TestDoAsEffectiveUser org.apache.hadoop.conf.TestConfiguration org.apache.hadoop.ipc.TestIPC +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4434//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4434//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4434//console This message is automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          Tests failed on UnknownHostException for asf901.ygridcore.net. Looking at findbugs issue.

          Show
          daryn Daryn Sharp added a comment - Tests failed on UnknownHostException for asf901.ygridcore.net. Looking at findbugs issue.
          Hide
          daryn Daryn Sharp added a comment -

          Findbugs already had an synch exclusion for the in/out streams. I changed it to exclude ipcStreams instead.

          Show
          daryn Daryn Sharp added a comment - Findbugs already had an synch exclusion for the in/out streams. I changed it to exclude ipcStreams instead.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12660152/HADOOP-10940.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ipc.TestRPCCallBenchmark
          org.apache.hadoop.net.TestNetUtils
          org.apache.hadoop.security.TestSecurityUtil
          org.apache.hadoop.ipc.TestRPC
          org.apache.hadoop.security.TestDoAsEffectiveUser
          org.apache.hadoop.conf.TestConfiguration
          org.apache.hadoop.ipc.TestIPC

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4435//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4435//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660152/HADOOP-10940.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ipc.TestRPCCallBenchmark org.apache.hadoop.net.TestNetUtils org.apache.hadoop.security.TestSecurityUtil org.apache.hadoop.ipc.TestRPC org.apache.hadoop.security.TestDoAsEffectiveUser org.apache.hadoop.conf.TestConfiguration org.apache.hadoop.ipc.TestIPC +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4435//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4435//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          nit: maxDataLength should be final, since it can't change

            \@InterfaceAudience.Private  // ONLY exposed for SaslRpcClient
            public static class IpcStreams implements Closeable {
          

          Is this comment still valid? It looks like even non-SASL clients are now using IpcStreams.

                // don't flush!  we need to avoid broken pipes if server closes or
                // rejects the connection.  the perils of multiple sends before a read
                // insecure: header+context+call, flush
                // secure  : header+negotiate, flush, (sasl), context+call, flush
          

          Hmm. I wonder if we could rephrase this to be clearer. Maybe something like "At this point, the data is buffered by the output stream. We do not want to flush yet, since that would generate unnecessary context switches. Another advantage of deferring the TCP write operation is that we do not get a "broken pipe" exception if the server closes or rejects the connection at this point."

                // again, don't flush!  see writeConnectionHeader
          

          Do we need this comment here? There wasn't a flush here earlier.

              public void sendRequest(RpcRequestHeaderProto header, Message request,
                  boolean flush) throws IOException {
                try {
                  header.writeDelimitedTo(dob);
                  request.writeDelimitedTo(dob);
                  sendRequest(dob, flush);
                } finally {
                  dob.reset();
                }
              }
          
              public void sendRequest(DataOutputBuffer buffer, boolean flush)
                  throws IOException {
                out.writeInt(buffer.size()); // total Length
                buffer.writeTo(out); // request header + payload
                if (flush) {
                  out.flush();
                }
              }
          

          Rather than having a boolean argument, why not just have the callers who want to flush call ioStreams.out.flush()? There seems to be no advantage to folding it into sendRequest, and it means that we need a comment to explain the value of the boolean everywhere.

            public boolean useWrap() {
          

          add VisibleForTesting?

          Show
          cmccabe Colin P. McCabe added a comment - nit: maxDataLength should be final, since it can't change \@InterfaceAudience.Private // ONLY exposed for SaslRpcClient public static class IpcStreams implements Closeable { Is this comment still valid? It looks like even non-SASL clients are now using IpcStreams . // don't flush! we need to avoid broken pipes if server closes or // rejects the connection. the perils of multiple sends before a read // insecure: header+context+call, flush // secure : header+negotiate, flush, (sasl), context+call, flush Hmm. I wonder if we could rephrase this to be clearer. Maybe something like "At this point, the data is buffered by the output stream. We do not want to flush yet, since that would generate unnecessary context switches. Another advantage of deferring the TCP write operation is that we do not get a "broken pipe" exception if the server closes or rejects the connection at this point." // again, don't flush! see writeConnectionHeader Do we need this comment here? There wasn't a flush here earlier. public void sendRequest(RpcRequestHeaderProto header, Message request, boolean flush) throws IOException { try { header.writeDelimitedTo(dob); request.writeDelimitedTo(dob); sendRequest(dob, flush); } finally { dob.reset(); } } public void sendRequest(DataOutputBuffer buffer, boolean flush) throws IOException { out.writeInt(buffer.size()); // total Length buffer.writeTo(out); // request header + payload if (flush) { out.flush(); } } Rather than having a boolean argument, why not just have the callers who want to flush call ioStreams.out.flush() ? There seems to be no advantage to folding it into sendRequest , and it means that we need a comment to explain the value of the boolean everywhere. public boolean useWrap() { add VisibleForTesting?
          Hide
          daryn Daryn Sharp added a comment -

          Is this comment still valid? It looks like even non-SASL clients are now using IpcStreams.

          A bit confused. What else is using it besides the ipc Client itself?

          I'll update the comment about why it shouldn't flush, but not sure if mentioning context switches is germane.

          Do we need this comment here? There wasn't a flush here earlier.

          It used to implicitly flush because the stream wasn't buffered (yet).

          why not just have the callers who want to flush call ioStreams.out.flush() ... it means that we need a comment to explain the value of the boolean everywhere.

          I had two considerations:

          1. I wanted to avoid exposing out as public just for SaslRpcClient
          2. The comments aren't intended to document the boolean but to convey the deliberate intent to (not) flush. Otherwise, someone may come along in the future and think "this is odd, a write with no flush? let's add a flush!" and accidentally re-introduce the bug.
          Show
          daryn Daryn Sharp added a comment - Is this comment still valid? It looks like even non-SASL clients are now using IpcStreams. A bit confused. What else is using it besides the ipc Client itself? I'll update the comment about why it shouldn't flush, but not sure if mentioning context switches is germane. Do we need this comment here? There wasn't a flush here earlier. It used to implicitly flush because the stream wasn't buffered (yet). why not just have the callers who want to flush call ioStreams.out.flush() ... it means that we need a comment to explain the value of the boolean everywhere. I had two considerations: I wanted to avoid exposing out as public just for SaslRpcClient The comments aren't intended to document the boolean but to convey the deliberate intent to (not) flush. Otherwise, someone may come along in the future and think "this is odd, a write with no flush? let's add a flush!" and accidentally re-introduce the bug.
          Hide
          daryn Daryn Sharp added a comment -

          Mark max length as final, update comments to clarify how flushing must be handled.

          Show
          daryn Daryn Sharp added a comment - Mark max length as final, update comments to clarify how flushing must be handled.
          Hide
          cmccabe Colin P. McCabe added a comment -

          A bit confused. What else is using it besides the ipc Client itself?

          OK, I think I see why this comment is there. SaslRpcClient is in the security namespace, so that motivates making this class public. So the comment is correct as-is. Sorry, my bad.

          It used to implicitly flush because the stream wasn't buffered (yet).

          OK. And now that we've disabled Nagle, we definitely don't want to be sending these small packets.

          [flush discussion]

          The boolean + comment spew on each invocation just looks really ugly to me. Can we make it an enum so it's self-documenting (NO_FLUSH, FLUSH)?

          Or just create IpcStreams#flush which calls out.flush, and have callers invoke this as needed.

          Show
          cmccabe Colin P. McCabe added a comment - A bit confused. What else is using it besides the ipc Client itself? OK, I think I see why this comment is there. SaslRpcClient is in the security namespace, so that motivates making this class public. So the comment is correct as-is. Sorry, my bad. It used to implicitly flush because the stream wasn't buffered (yet). OK. And now that we've disabled Nagle, we definitely don't want to be sending these small packets. [flush discussion] The boolean + comment spew on each invocation just looks really ugly to me. Can we make it an enum so it's self-documenting (NO_FLUSH, FLUSH)? Or just create IpcStreams#flush which calls out.flush , and have callers invoke this as needed.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12661758/HADOOP-10940.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4472//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4472//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12661758/HADOOP-10940.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4472//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4472//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 6s The applied patch generated 4 new checkstyle issues (total was 204, now 204).
          -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 23m 4s Tests passed in hadoop-common.
              60m 6s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12661758/HADOOP-10940.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6ae2a0d
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 6s The applied patch generated 4 new checkstyle issues (total was 204, now 204). -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 4s Tests passed in hadoop-common.     60m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12661758/HADOOP-10940.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6439/console This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Moving bugs out of previously closed releases into the next minor release 2.8.0.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Moving bugs out of previously closed releases into the next minor release 2.8.0.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12661758/HADOOP-10940.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d3797f9
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7095/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12661758/HADOOP-10940.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d3797f9 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7095/console This message was automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          Patch is up to date. Added flush as request by Colin P. McCabe and created a distinct config key for the client vs. server.

          Show
          daryn Daryn Sharp added a comment - Patch is up to date. Added flush as request by Colin P. McCabe and created a distinct config key for the client vs. server.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 19m 17s trunk passed
          +1 compile 35m 10s trunk passed with JDK v1.8.0_66
          +1 compile 22m 0s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 57s trunk passed
          +1 mvnsite 3m 33s trunk passed
          +1 mvneclipse 0m 45s trunk passed
          +1 findbugs 6m 2s trunk passed
          +1 javadoc 3m 15s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 38s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 39s the patch passed
          +1 compile 34m 9s the patch passed with JDK v1.8.0_66
          +1 javac 34m 9s the patch passed
          +1 compile 20m 39s the patch passed with JDK v1.7.0_91
          +1 javac 20m 39s the patch passed
          -1 checkstyle 0m 37s Patch generated 4 new checkstyle issues in hadoop-common-project/hadoop-common (total was 278, now 278).
          +1 mvnsite 2m 26s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 50s the patch passed
          +1 javadoc 2m 20s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 19s the patch passed with JDK v1.7.0_91
          -1 unit 19m 30s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 17m 50s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 39s Patch generated 1 ASF License warnings.
          206m 1s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.crypto.key.TestCachingKeyProvider
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestFind
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.ipc.TestIPC
          JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.io.compress.TestCodecPool
            hadoop.crypto.key.TestCachingKeyProvider
            hadoop.security.token.delegation.web.TestWebDelegationToken
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestFind
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.ipc.TestProtoBufRpc



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777791/HADOOP-10940.patch
          JIRA Issue HADOOP-10940
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2f3faecb6752 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0c3a53e
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 19m 17s trunk passed +1 compile 35m 10s trunk passed with JDK v1.8.0_66 +1 compile 22m 0s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 57s trunk passed +1 mvnsite 3m 33s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 6m 2s trunk passed +1 javadoc 3m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 38s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 39s the patch passed +1 compile 34m 9s the patch passed with JDK v1.8.0_66 +1 javac 34m 9s the patch passed +1 compile 20m 39s the patch passed with JDK v1.7.0_91 +1 javac 20m 39s the patch passed -1 checkstyle 0m 37s Patch generated 4 new checkstyle issues in hadoop-common-project/hadoop-common (total was 278, now 278). +1 mvnsite 2m 26s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 50s the patch passed +1 javadoc 2m 20s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 19s the patch passed with JDK v1.7.0_91 -1 unit 19m 30s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 17m 50s hadoop-common in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 39s Patch generated 1 ASF License warnings. 206m 1s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.crypto.key.TestCachingKeyProvider   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestRPCWaitForProxy   hadoop.ipc.TestIPC JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.io.compress.TestCodecPool   hadoop.crypto.key.TestCachingKeyProvider   hadoop.security.token.delegation.web.TestWebDelegationToken   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestRPCWaitForProxy   hadoop.ipc.TestProtoBufRpc Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777791/HADOOP-10940.patch JIRA Issue HADOOP-10940 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f3faecb6752 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0c3a53e findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8247/console This message was automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          Addressed style warnings. Tests pass for me, pre-commit has become so unreliable.

          Show
          daryn Daryn Sharp added a comment - Addressed style warnings. Tests pass for me, pre-commit has become so unreliable.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 26m 35s trunk passed
          +1 compile 36m 46s trunk passed with JDK v1.8.0_66
          +1 compile 30m 30s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 3m 58s trunk passed
          +1 mvneclipse 0m 49s trunk passed
          +1 findbugs 6m 42s trunk passed
          +1 javadoc 3m 43s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 47s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 56s the patch passed
          +1 compile 32m 43s the patch passed with JDK v1.8.0_66
          +1 javac 32m 43s the patch passed
          +1 compile 20m 25s the patch passed with JDK v1.7.0_91
          +1 javac 20m 25s the patch passed
          +1 checkstyle 0m 43s the patch passed
          +1 mvnsite 2m 25s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 52s the patch passed
          +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 22s the patch passed with JDK v1.7.0_91
          -1 unit 19m 18s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 16m 47s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 56s Patch does not generate ASF License warnings.
          223m 33s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.fs.TestLocalFsFCStatistics
            hadoop.fs.shell.find.TestAnd
            hadoop.io.compress.TestCodecPool
            hadoop.fs.shell.find.TestPrint0
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestFind
            hadoop.ipc.TestRPCWaitForProxy
          JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.io.compress.TestCodecPool
            hadoop.crypto.key.TestCachingKeyProvider
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestFind
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.ipc.TestIPC
            hadoop.ipc.TestProtoBufRpc



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch
          JIRA Issue HADOOP-10940
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ba2fd9994d09 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 607473e
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 26m 35s trunk passed +1 compile 36m 46s trunk passed with JDK v1.8.0_66 +1 compile 30m 30s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 6s trunk passed +1 mvnsite 3m 58s trunk passed +1 mvneclipse 0m 49s trunk passed +1 findbugs 6m 42s trunk passed +1 javadoc 3m 43s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 47s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 56s the patch passed +1 compile 32m 43s the patch passed with JDK v1.8.0_66 +1 javac 32m 43s the patch passed +1 compile 20m 25s the patch passed with JDK v1.7.0_91 +1 javac 20m 25s the patch passed +1 checkstyle 0m 43s the patch passed +1 mvnsite 2m 25s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 52s the patch passed +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 22s the patch passed with JDK v1.7.0_91 -1 unit 19m 18s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 16m 47s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 56s Patch does not generate ASF License warnings. 223m 33s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.fs.TestLocalFsFCStatistics   hadoop.fs.shell.find.TestAnd   hadoop.io.compress.TestCodecPool   hadoop.fs.shell.find.TestPrint0   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestRPCWaitForProxy JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.io.compress.TestCodecPool   hadoop.crypto.key.TestCachingKeyProvider   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestRPCWaitForProxy   hadoop.ipc.TestIPC   hadoop.ipc.TestProtoBufRpc Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch JIRA Issue HADOOP-10940 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ba2fd9994d09 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 607473e findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8256/console This message was automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          The failed tests pass for me locally. Would someone please verify? Wasting my time on bizarre pre-commit failures is really irking me...

          Show
          daryn Daryn Sharp added a comment - The failed tests pass for me locally. Would someone please verify? Wasting my time on bizarre pre-commit failures is really irking me...
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 40s trunk passed
          +1 compile 5m 59s trunk passed with JDK v1.8.0_72
          +1 compile 6m 46s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 5s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 40s the patch passed
          +1 compile 5m 48s the patch passed with JDK v1.8.0_72
          +1 javac 5m 48s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.7.0_95
          +1 javac 6m 44s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 0 new + 268 unchanged - 4 fixed = 268 total (was 272)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 1s the patch passed with JDK v1.7.0_95
          -1 unit 6m 29s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          58m 24s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch
          JIRA Issue HADOOP-10940
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 305873995c18 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2137e8f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 40s trunk passed +1 compile 5m 59s trunk passed with JDK v1.8.0_72 +1 compile 6m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 48s the patch passed with JDK v1.8.0_72 +1 javac 5m 48s the patch passed +1 compile 6m 44s the patch passed with JDK v1.7.0_95 +1 javac 6m 44s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 0 new + 268 unchanged - 4 fixed = 268 total (was 272) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_95 -1 unit 6m 29s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 58m 24s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch JIRA Issue HADOOP-10940 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 305873995c18 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2137e8f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8757/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I can see the need for this; it's just beyond my competence level to review. sorry

          Show
          stevel@apache.org Steve Loughran added a comment - I can see the need for this; it's just beyond my competence level to review. sorry
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 43s trunk passed
          +1 compile 5m 48s trunk passed with JDK v1.8.0_72
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 5m 50s the patch passed with JDK v1.8.0_72
          +1 javac 5m 50s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 0 new + 268 unchanged - 4 fixed = 268 total (was 272)
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 1s the patch passed with JDK v1.7.0_95
          +1 unit 6m 45s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 6m 57s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          58m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch
          JIRA Issue HADOOP-10940
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 275a2b8f90a1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 27e0681
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8763/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8763/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 43s trunk passed +1 compile 5m 48s trunk passed with JDK v1.8.0_72 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 50s the patch passed with JDK v1.8.0_72 +1 javac 5m 50s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 0 new + 268 unchanged - 4 fixed = 268 total (was 272) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_95 +1 unit 6m 45s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 6m 57s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 58m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch JIRA Issue HADOOP-10940 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 275a2b8f90a1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27e0681 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8763/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8763/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 3s HADOOP-10940 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch
          JIRA Issue HADOOP-10940
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9402/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 3s HADOOP-10940 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch JIRA Issue HADOOP-10940 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9402/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Daryn Sharp, would you be able to update the patch for review?

          Show
          sjlee0 Sangjin Lee added a comment - Daryn Sharp , would you be able to update the patch for review?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Not much going on here for a long time, dropping from 2.8.0.

          Not putting any target-version either anymore, let's target this depending on when there is patch activity.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Not much going on here for a long time, dropping from 2.8.0. Not putting any target-version either anymore, let's target this depending on when there is patch activity.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s HADOOP-10940 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-10940
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10451/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HADOOP-10940 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-10940 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778043/HADOOP-10940.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10451/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 8s HADOOP-10940 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-10940
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827616/HADOOP-10940.1.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10463/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HADOOP-10940 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-10940 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827616/HADOOP-10940.1.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10463/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          The former HADOOP-10940.1.patch applies to branch-2.

          HADOOP-10940.trunk.1.patch applies to trunk. The conflict is due to another jira randomly removing leading whitespace on blank lines not in the vicinity of the change.

          Show
          daryn Daryn Sharp added a comment - The former HADOOP-10940 .1.patch applies to branch-2. HADOOP-10940 .trunk.1.patch applies to trunk. The conflict is due to another jira randomly removing leading whitespace on blank lines not in the vicinity of the change.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 48s trunk passed
          +1 compile 6m 55s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 6m 45s the patch passed
          +1 javac 6m 45s the patch passed
          -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 345 unchanged - 3 fixed = 346 total (was 348)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 25s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 8m 7s hadoop-common in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          38m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10940
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827749/HADOOP-10940.trunk.1.patch
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0269bce80dac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / baab489
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10471/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10471/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10471/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 48s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 45s the patch passed +1 javac 6m 45s the patch passed -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 345 unchanged - 3 fixed = 346 total (was 348) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 7s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 38m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10940 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827749/HADOOP-10940.trunk.1.patch Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0269bce80dac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / baab489 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10471/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10471/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10471/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          The patch looks good in general. We have also been running it in production internally for quite a while.
          One nit. The new config variable needs to be added/documented in core-default.xml.

          Show
          kihwal Kihwal Lee added a comment - The patch looks good in general. We have also been running it in production internally for quite a while. One nit. The new config variable needs to be added/documented in core-default.xml .
          Hide
          daryn Daryn Sharp added a comment -

          Updated core-default as requested. Thanks.

          Show
          daryn Daryn Sharp added a comment - Updated core-default as requested. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 59s trunk passed
          +1 compile 6m 53s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 46s the patch passed
          +1 javac 6m 46s the patch passed
          -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 345 unchanged - 3 fixed = 346 total (was 348)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 1m 25s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 7m 50s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          38m 28s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-10940
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827765/HADOOP-10940.trunk.2.patch
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 63172d034095 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / baab489
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10472/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10472/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10472/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 59s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 46s the patch passed +1 javac 6m 46s the patch passed -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 345 unchanged - 3 fixed = 346 total (was 348) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 7m 50s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-10940 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827765/HADOOP-10940.trunk.2.patch Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 63172d034095 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / baab489 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10472/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10472/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10472/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          +1 the patch looks good.

          Show
          kihwal Kihwal Lee added a comment - +1 the patch looks good.
          Hide
          kihwal Kihwal Lee added a comment -

          I've committed this to trunk, branch-2 and branch-2.8.

          Show
          kihwal Kihwal Lee added a comment - I've committed this to trunk, branch-2 and branch-2.8.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10418 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10418/)
          HADOOP-10940. RPC client does no bounds checking of responses. (kihwal: rev d4d076876a8d0002bd3a73491d8459d11cb4896c)

          • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • (edit) hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10418 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10418/ ) HADOOP-10940 . RPC client does no bounds checking of responses. (kihwal: rev d4d076876a8d0002bd3a73491d8459d11cb4896c) (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java (edit) hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development