[HADOOP-10733] Potential null dereference in CredentialShell#promptForCredential()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 21/Jun/14 03:45
• Updated: 01/Dec/14 03:11
• Resolved: 17/Jul/14 18:13

Description

      char[] newPassword1 = c.readPassword("Enter password: ");
      char[] newPassword2 = c.readPassword("Enter password again: ");
      noMatch = !Arrays.equals(newPassword1, newPassword2);
      if (noMatch) {
        Arrays.fill(newPassword1, ' ');

newPassword1 might be null, leading to NullPointerException in Arrays.fill() call.
Similar issue for the following call on line 381:

      Arrays.fill(newPassword2, ' ');