Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: HADOOP-10388
    • Fix Version/s: HADOOP-10388
    • Component/s: None
    • Labels:
      None

      Description

      In GenerateProtobufs.cmake, pb-c.h.s files are not added to output, so when make clean is called, those files are not cleaned.

               add_custom_command(
                  OUTPUT ${PB_C_FILE} ${PB_H_FILE} ${CALL_C_FILE} ${CALL_H_FILE}
      

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647044/HADOOP-10631.v1.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3977//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647044/HADOOP-10631.v1.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3977//console This message is automatically generated.
        Hide
        Colin Patrick McCabe added a comment -

        +1. Thanks, Binglin.

        Show
        Colin Patrick McCabe added a comment - +1. Thanks, Binglin.
        Hide
        Binglin Chang added a comment -

        Thanks for the review, Colin.

        Show
        Binglin Chang added a comment - Thanks for the review, Colin.

          People

          • Assignee:
            Binglin Chang
            Reporter:
            Binglin Chang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development