Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: HADOOP-10388
    • Fix Version/s: HADOOP-10388
    • Component/s: None
    • Labels:
      None

      Description

      In GenerateProtobufs.cmake, pb-c.h.s files are not added to output, so when make clean is called, those files are not cleaned.

               add_custom_command(
                  OUTPUT ${PB_C_FILE} ${PB_H_FILE} ${CALL_C_FILE} ${CALL_H_FILE}
      

        Activity

        Binglin Chang created issue -
        Binglin Chang made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Binglin Chang made changes -
        Attachment HADOOP-10631.v1.patch [ 12647044 ]
        Binglin Chang made changes -
        Affects Version/s HADOOP-10388 [ 12326650 ]
        Binglin Chang made changes -
        Target Version/s HADOOP-10388 [ 12326650 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647044/HADOOP-10631.v1.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3977//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647044/HADOOP-10631.v1.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3977//console This message is automatically generated.
        Hide
        Colin Patrick McCabe added a comment -

        +1. Thanks, Binglin.

        Show
        Colin Patrick McCabe added a comment - +1. Thanks, Binglin.
        Colin Patrick McCabe made changes -
        Summary Native Hadoop Client: Add missing output in GenerateProtobufs.cmake Native Hadoop Client: make clean should remove pb-c.h.s files
        Colin Patrick McCabe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s HADOOP-10388 [ 12326650 ]
        Resolution Fixed [ 1 ]
        Hide
        Binglin Chang added a comment -

        Thanks for the review, Colin.

        Show
        Binglin Chang added a comment - Thanks for the review, Colin.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        42s 1 Binglin Chang 28/May/14 04:28
        Patch Available Patch Available Resolved Resolved
        14h 19m 1 Colin Patrick McCabe 28/May/14 18:47

          People

          • Assignee:
            Binglin Chang
            Reporter:
            Binglin Chang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development