Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: HADOOP-10388
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    1. HADOOP-10577.v2.patch
      3 kB
      Binglin Chang
    2. HADOOP-10577.v1.patch
      3 kB
      Binglin Chang

      Activity

      Hide
      Binglin Chang added a comment -

      Changes:
      1. find_library should not use .so suffix for cross platform compatibility
      2. clang/libc++ does not have <tr1/memory>, just <memory>
      3. wrong printf usage %Zd, should be %zu?

      code on current branch can now compile at macosx on my laptop with the change.

      Show
      Binglin Chang added a comment - Changes: 1. find_library should not use .so suffix for cross platform compatibility 2. clang/libc++ does not have <tr1/memory>, just <memory> 3. wrong printf usage %Zd, should be %zu? code on current branch can now compile at macosx on my laptop with the change.
      Hide
      Binglin Chang added a comment -

      update a little, found wrong usage of sem_post/sem_wait

      Show
      Binglin Chang added a comment - update a little, found wrong usage of sem_post/sem_wait
      Hide
      Luke Lu added a comment -

      lgtm. +1.

      Show
      Luke Lu added a comment - lgtm. +1.
      Hide
      Binglin Chang added a comment -

      Thanks for the review Luke! I have committed this.

      Show
      Binglin Chang added a comment - Thanks for the review Luke! I have committed this.
      Hide
      Colin Patrick McCabe added a comment -

      thanks, guys. +1

      Show
      Colin Patrick McCabe added a comment - thanks, guys. +1

        People

        • Assignee:
          Binglin Chang
          Reporter:
          Binglin Chang
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development