Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      From HIVE-6430 code review

      1. HADOOP-10555.patch
        1 kB
        Sergey Shelukhin

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1434 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1434/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1434 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1434/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #710 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/710/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #710 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/710/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2639 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2639/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2639 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2639/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #698 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/698/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #698 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/698/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8851 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8851/)
        HADOOP-10555. Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8851 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8851/ ) HADOOP-10555 . Add offset support to MurmurHash. Contributed by Sergey (wheat9: rev aac260faa15d69218f179b6475607fc63af31a53) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/hash/MurmurHash.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Sergey Shelukhin for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Sergey Shelukhin for the contribution.
        Hide
        wheat9 Haohui Mai added a comment -

        +1

        Show
        wheat9 Haohui Mai added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 4s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 22m 56s Tests passed in hadoop-common.
            59m 50s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12642760/HADOOP-10555.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6ae2a0d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6427/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6427/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6427/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 56s Tests passed in hadoop-common.     59m 50s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12642760/HADOOP-10555.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6427/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6427/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6427/console This message was automatically generated.
        Hide
        sershe Sergey Shelukhin added a comment -

        Gopal V fyi

        Show
        sershe Sergey Shelukhin added a comment - Gopal V fyi
        Hide
        sershe Sergey Shelukhin added a comment -

        can someone please assign to me? I don't have permissions to assign

        Show
        sershe Sergey Shelukhin added a comment - can someone please assign to me? I don't have permissions to assign

          People

          • Assignee:
            sershe Sergey Shelukhin
            Reporter:
            sershe Sergey Shelukhin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development