Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Most of the constants in proxyusers have public visibility unnecessarily.
      These public constants should be set to private and their external usage should be replaced by the corresponding functions.

      1. HADOOP-10471.patch
        2 kB
        Benoy Antony
      2. HADOOP-10471.patch
        1 kB
        Benoy Antony

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1777 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1777/)
          HADOOP-10471. Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1777 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1777/ ) HADOOP-10471 . Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1751 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1751/)
          HADOOP-10471. Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1751 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1751/ ) HADOOP-10471 . Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #559 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/559/)
          HADOOP-10471. Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #559 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/559/ ) HADOOP-10471 . Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5595 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5595/)
          HADOOP-10471. Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5595 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5595/ ) HADOOP-10471 . Reduce the visibility of constants in ProxyUsers. Contributed by Benoy Antony. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592915 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ProxyUsers.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/common/TestJspHelper.java
          Hide
          Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Benoy Antony for the contribution.

          Show
          Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Benoy Antony for the contribution.
          Hide
          Haohui Mai added a comment -

          I'll commit it shortly.

          Show
          Haohui Mai added a comment - I'll commit it shortly.
          Hide
          Daryn Sharp added a comment -

          +1 Simple enough change.

          Show
          Daryn Sharp added a comment - +1 Simple enough change.
          Hide
          Benoy Antony added a comment -

          The test failures are unrelated.

          Show
          Benoy Antony added a comment - The test failures are unrelated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12643486/HADOOP-10471.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3917//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3917//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643486/HADOOP-10471.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3917//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3917//console This message is automatically generated.
          Hide
          Benoy Antony added a comment -

          Attaching combined patch which includes HDFS-6202

          Show
          Benoy Antony added a comment - Attaching combined patch which includes HDFS-6202
          Hide
          Benoy Antony added a comment -

          Thanks Haohui Mai . HDFS-6202 needs to be done first for this patch to compile.

          Show
          Benoy Antony added a comment - Thanks Haohui Mai . HDFS-6202 needs to be done first for this patch to compile.
          Hide
          Haohui Mai added a comment -

          +1 pending jenkins.

          Show
          Haohui Mai added a comment - +1 pending jenkins.
          Hide
          Benoy Antony added a comment -

          Haohui Mai, could you please review this jira as well its dependency HDFS-6202 ?

          Show
          Benoy Antony added a comment - Haohui Mai , could you please review this jira as well its dependency HDFS-6202 ?
          Hide
          Benoy Antony added a comment -

          Confirmed that HBase and Hive does not access these constants directly. So changing the visibility to private should not impact these compnents

          Show
          Benoy Antony added a comment - Confirmed that HBase and Hive does not access these constants directly. So changing the visibility to private should not impact these compnents
          Hide
          Benoy Antony added a comment -

          Attaching a patch.
          No tests are added since this is a minor refactoring with no behavioral change.

          Show
          Benoy Antony added a comment - Attaching a patch. No tests are added since this is a minor refactoring with no behavioral change.

            People

            • Assignee:
              Benoy Antony
              Reporter:
              Benoy Antony
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development