[HADOOP-10441] Namenode metric "rpc.RetryCache/NameNodeRetryCache.CacheHit" can't be correctly processed by Ganglia

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: metrics
• Hadoop Flags: Reviewed
• Assignee: Jing Zhao
• Reporter: Jing Zhao
• Created: 26/Mar/14 17:49
• Updated: 10/Apr/14 13:11
• Resolved: 26/Mar/14 20:38

Description

The issue is reported by dsen:

Recently added Namenode metric "rpc.RetryCache/NameNodeRetryCache.CacheHit" can't be correctly processed by Ganglia because its name contains "/"

Proposal: Namenode metric "rpc.RetryCache/NameNodeRetryCache.CacheHit" should be renamed to "rpc.RetryCache.NameNodeRetryCache.CacheHit"
Here - org.apache.hadoop.ipc.metrics.RetryCacheMetrics#RetryCacheMetrics

  RetryCacheMetrics(RetryCache retryCache) {
    name = "RetryCache/"+ retryCache.getCacheName();
    registry = new MetricsRegistry(name);
    if (LOG.isDebugEnabled()) {
      LOG.debug("Initialized "+ registry);
    }
  }