I'm attaching a patch. This was discovered while testing HDFS ACLs with dfs.client.retry.policy.enabled set to true. Running the ls command would print a stack trace if the NameNode does not have ACLs enabled, or if the NameNode is pre-2.4 and therefore does not have the ACL RPC endpoints defined. The same log message is logged at both debug and info level. Retries are supposed to be transparent to the client, so it's appropriate for this logging to be at debug level, and we can remove the redundant info level log.

+1 patch looks good.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12636420/HADOOP-10422.1.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. There were no new javadoc warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3701//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3701//console

This message is automatically generated.

I committed this to trunk, branch-2 and branch-2.4. Nicholas, thank you for the code review.

-1 tests included. The patch doesn't appear to include any new or modified tests.

This was a change in logging only. I tested manually by confirming that the redundant log message goes away when running ls, and I also confirmed that it can be turned back on by changing log level to debug.

SUCCESS: Integrated in Hadoop-trunk-Commit #5394 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5394/)
HADOOP-10422. Remove redundant logging of RPC retry attempts. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581112)

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java

FAILURE: Integrated in Hadoop-Yarn-trunk #520 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/520/)
HADOOP-10422. Remove redundant logging of RPC retry attempts. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581112)

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1737 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1737/)
HADOOP-10422. Remove redundant logging of RPC retry attempts. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581112)

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java

FAILURE: Integrated in Hadoop-Hdfs-trunk #1712 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1712/)
HADOOP-10422. Remove redundant logging of RPC retry attempts. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581112)

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java