[HADOOP-10404] Some accesses to DomainSocketWatcher#closed are not protected by lock

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Target Version/s: 2.6.0
• Assignee: Colin McCabe
• Reporter: Ted Yu
• Created: 12/Mar/14 04:21
• Updated: 20/Feb/15 21:13
• Resolved: 06/Oct/14 21:41

Description

   * Lock which protects toAdd, toRemove, and closed.
   */
  private final ReentrantLock lock = new ReentrantLock();

There're two places, NotificationHandler.handle() and kick(), where access to closed is without holding lock.

Issue Links

• is duplicated by: HDFS-7212 FsDatasetImpl#createTemporary sometimes holds the FSDatasetImpl lock for a very long time
• is related to: HADOOP-11604 Prevent ConcurrentModificationException while closing domain sockets during shutdown of DomainSocketWatcher thread.