Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10366

Add whitespaces between the classes for values in core-default.xml to fit better in browser

    Details

    • Hadoop Flags:
      Reviewed

      Description

      The io.serialization property in core-default.xml has a very long value in a single line, as below

      <property>
        <name>io.serializations</name>
        <value>org.apache.hadoop.io.serializer.WritableSerialization,org.apache.hadoop.io.serializer.avro.AvroSpecificSerialization,org.apache.hadoop.io.serializer.avro.AvroReflectSerialization</value>
        <description>A list of serialization classes that can be used for
        obtaining serializers and deserializers.</description>
      </property>
      

      which not only break the code style (a very long line) but also not fit well in browser. Due to this single very long line, the "description" column can not show in browser by default

      1. HADOOP-10366.patch
        0.9 kB
        Chengwei Yang
      2. HADOOP-10366-03.patch
        2 kB
        Kanaka Kumar Avvaru
      3. HADOOP-10366-04.patch
        3 kB
        Kanaka Kumar Avvaru
      4. HADOOP-10366-wrap01
        2 kB
        Kanaka Kumar Avvaru
      5. HADOOP-10366-wrap01.patch
        2 kB
        Kanaka Kumar Avvaru
      6. HADOOP-10366-wrap02.patch
        2 kB
        Kanaka Kumar Avvaru

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Chengwei, thanks for addressing this.

        I am not very familiar with XML/XSL but I wonder if there is a way to get the text wrapping via XSL transformation (see configuration.xsl). That way we don't need to insert spurious spaces in the default value and it works for all such entries.

        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Chengwei, thanks for addressing this. I am not very familiar with XML/XSL but I wonder if there is a way to get the text wrapping via XSL transformation (see configuration.xsl). That way we don't need to insert spurious spaces in the default value and it works for all such entries.
        Hide
        chengwei-yang Chengwei Yang added a comment -

        Yes, for the configuration.xsl, I think it's prefer another patch to enhance it, say automatically wrap line in column with textwidth = 80 for example.

        This patch in other side, also fix the coding style, so far, this is the only very long line here.

        Show
        chengwei-yang Chengwei Yang added a comment - Yes, for the configuration.xsl, I think it's prefer another patch to enhance it, say automatically wrap line in column with textwidth = 80 for example. This patch in other side, also fix the coding style, so far, this is the only very long line here.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        As the issue is stale from about a year, I would like to work on it and give a patch. Chengwei Yang if you would like to continue work on it, please feel free to assign it back to you.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - As the issue is stale from about a year, I would like to work on it and give a patch. Chengwei Yang if you would like to continue work on it, please feel free to assign it back to you.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Attached a patch HADOOP-10366-wrap01.patch as per the suggestions in the earlier comments to wrap the value with line size of 80.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Attached a patch HADOOP-10366 -wrap01.patch as per the suggestions in the earlier comments to wrap the value with line size of 80.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12723357/HADOOP-10366-wrap01.patch
        against trunk revision 53959e6.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6067//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6067//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723357/HADOOP-10366-wrap01.patch against trunk revision 53959e6. +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6067//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6067//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 51s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 common tests 23m 24s Tests passed in hadoop-common.
            58m 0s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12723357/HADOOP-10366-wrap01.patch
        Optional Tests javadoc javac unit
        git revision trunk / f24452d
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 common tests 23m 24s Tests passed in hadoop-common.     58m 0s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12723357/HADOOP-10366-wrap01.patch Optional Tests javadoc javac unit git revision trunk / f24452d whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6675/console This message was automatically generated.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Updating patch for PreCommit build errors with spaces.
        New test cases not required as the patch is on document.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Updating patch for PreCommit build errors with spaces. New test cases not required as the patch is on document.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 50s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 22m 29s Tests passed in hadoop-common.
            57m 3s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732509/HADOOP-10366-wrap02.patch
        Optional Tests javadoc javac unit
        git revision trunk / 92c38e4
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6683/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6683/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6683/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 22m 29s Tests passed in hadoop-common.     57m 3s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732509/HADOOP-10366-wrap02.patch Optional Tests javadoc javac unit git revision trunk / 92c38e4 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6683/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6683/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6683/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Kanaka Kumar Avvaru, thank you for taking this issue.
        I don't think it's a good idea to render the value in the fixed number of characters. Users may copy and paste the parameter, which is rendered in the middle of the classes, from browser. As the result, application can fail.
        I'm thinking it makes more sense to add a whitespace between the classes as follows:

        <value>org.apache.hadoop.io.serializer.WritableSerialization, org.apache.hadoop.io.serializer.avro.AvroSpecificSerialization, org.apache.hadoop.io.serializer.avro.AvroReflectSerialization</value>
        

        That way we can fix the problem. When the value is read from o.a.h.io.serializer.SerializationFactory, the whitespaces are trimmed.

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Kanaka Kumar Avvaru , thank you for taking this issue. I don't think it's a good idea to render the value in the fixed number of characters. Users may copy and paste the parameter, which is rendered in the middle of the classes, from browser. As the result, application can fail. I'm thinking it makes more sense to add a whitespace between the classes as follows: <value>org.apache.hadoop.io.serializer.WritableSerialization, org.apache.hadoop.io.serializer.avro.AvroSpecificSerialization, org.apache.hadoop.io.serializer.avro.AvroReflectSerialization</value> That way we can fix the problem. When the value is read from o.a.h.io.serializer.SerializationFactory, the whitespaces are trimmed.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Thanks for the inputs Akira Ajisaka, I agree with you.

        Updated the patch to handle issue by adding spaces for the lengthy values for properties io.serializations & hadoop.security.crypto.codec.classes.aes.ctr.nopadding.

        I have observed o.a.h.crypto.CryptoCodec also trims the spaces while identifying codec classes from configuration hadoop.security.crypto.codec.classes.aes.ctr.nopadding. Please review if it can cause problem in other places.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Thanks for the inputs Akira Ajisaka , I agree with you. Updated the patch to handle issue by adding spaces for the lengthy values for properties io.serializations & hadoop.security.crypto.codec.classes.aes.ctr.nopadding . I have observed o.a.h.crypto.CryptoCodec also trims the spaces while identifying codec classes from configuration hadoop.security.crypto.codec.classes.aes.ctr.nopadding . Please review if it can cause problem in other places.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 36s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 31s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 22m 43s Tests passed in hadoop-common.
            56m 55s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12733533/HADOOP-10366-03.patch
        Optional Tests javadoc javac unit
        git revision trunk / 363c355
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6727/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6727/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6727/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 31s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 22m 43s Tests passed in hadoop-common.     56m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733533/HADOOP-10366-03.patch Optional Tests javadoc javac unit git revision trunk / 363c355 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6727/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6727/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6727/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1. Thanks Kanaka Kumar Avvaru for fixing hadoop.security.crypto.codec.classes.aes.ctr.nopadding as well.

        Show
        ajisakaa Akira Ajisaka added a comment - +1. Thanks Kanaka Kumar Avvaru for fixing hadoop.security.crypto.codec.classes.aes.ctr.nopadding as well.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Cancelling my +1. Would you fix TransparentEncryption.md as well?

        #### hadoop.security.crypto.codec.classes.aes.ctr.nopadding
        
        Default: `org.apache.hadoop.crypto.OpensslAesCtrCryptoCodec,org.apache.hadoop.crypto.JceAesCtrCryptoCodec`
        
        Show
        ajisakaa Akira Ajisaka added a comment - Cancelling my +1. Would you fix TransparentEncryption.md as well? #### hadoop.security.crypto.codec.classes.aes.ctr.nopadding Default: `org.apache.hadoop.crypto.OpensslAesCtrCryptoCodec,org.apache.hadoop.crypto.JceAesCtrCryptoCodec`
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Thanks Akira Ajisaka for the suggestion. Here I have attached new patch which includes correction in TransparentEncryption.md

        But TransparentEncryption.md is in hadoop-hdfs source. Is it fine to correct as part of this JIRA which is on Hadoop Common?

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Thanks Akira Ajisaka for the suggestion. Here I have attached new patch which includes correction in TransparentEncryption.md But TransparentEncryption.md is in hadoop-hdfs source. Is it fine to correct as part of this JIRA which is on Hadoop Common?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Kanaka Kumar Avvaru for updating the patch.

        Is it fine to correct as part of this JIRA which is on Hadoop Common?

        It's fine because the fix is trivial for HDFS project. There are typically 3 reasons to split the patch into different projects : https://issues.apache.org/jira/browse/YARN-3587?focusedCommentId=14534625&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14534625

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Kanaka Kumar Avvaru for updating the patch. Is it fine to correct as part of this JIRA which is on Hadoop Common? It's fine because the fix is trivial for HDFS project. There are typically 3 reasons to split the patch into different projects : https://issues.apache.org/jira/browse/YARN-3587?focusedCommentId=14534625&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14534625
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 58s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 9m 47s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 2s Site still builds.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 23m 0s Tests passed in hadoop-common.
        -1 hdfs tests 152m 35s Tests failed in hadoop-hdfs.
            216m 40s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestDeadDatanode
          hadoop.hdfs.server.namenode.TestTransferFsImage
          hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
          hadoop.hdfs.server.namenode.TestMetaSave
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734095/HADOOP-10366-04.patch
        Optional Tests javadoc javac unit site
        git revision trunk / ce53c8e
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 58s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 2s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 23m 0s Tests passed in hadoop-common. -1 hdfs tests 152m 35s Tests failed in hadoop-hdfs.     216m 40s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestDeadDatanode   hadoop.hdfs.server.namenode.TestTransferFsImage   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.server.namenode.TestMetaSave Timed out tests org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734095/HADOOP-10366-04.patch Optional Tests javadoc javac unit site git revision trunk / ce53c8e hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6785/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1. I'll commit this shortly.

        Show
        ajisakaa Akira Ajisaka added a comment - +1. I'll commit this shortly.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Kanaka Kumar Avvaru for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Kanaka Kumar Avvaru for the contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7880/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7880/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/934/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/934/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/)
        HADOOP-10366. Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/ ) HADOOP-10366 . Add whitespaces between classes for values in core-default.xml to fit better in browser. Contributed by kanaka kumar avvaru. (aajisaka: rev 0e4f1081c7a98e1c0c4f922f5e2afe467a0d763f) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Thank you Akira Ajisaka for the reviews and commit.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Thank you Akira Ajisaka for the reviews and commit.

          People

          • Assignee:
            kanaka Kanaka Kumar Avvaru
            Reporter:
            chengwei-yang Chengwei Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development