[HADOOP-10363] Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 25/Feb/14 04:11
• Updated: 08/May/15 22:31
• Resolved: 08/May/15 22:31

Description

Here is related code:

      try {
        for(in = new SequenceFile.Reader(fs, srcs, job); in.next(key, value); ) {
...
      finally {
        in.close();
      }

    SequenceFile.Writer opWriter = null;
    try {
      opWriter = SequenceFile.createWriter(fs, jobconf, opList, Text.class,
          FileOperation.class, SequenceFile.CompressionType.NONE);
...
    } finally {
      opWriter.close();
    }

If ctor of Reader / Writer throws exception, the close() would be called on null object.