Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: bin
    • Labels:
    • Environment:

      Windows

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are two small things in winutils/chmod.c:

      pathName should be pointer to a constant WSTR
      the declartion

      LPWSTR pathName = NULL;

      seems to be wrong.

      LPCWSTR pathName = NULL;
      should b used instead.

      ------------------------------------------------

      I believe the fragment

      switch (c)
      {
      case NULL:

      to be wrong as pointers are not permitted as
      case values.

      ------------------------------------------------

      1. HADOOP-10356.patch
        0.9 kB
        René Nyffenegger

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3597//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3597//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3597//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3597//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 17s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 common tests 23m 33s Tests passed in hadoop-common.
            39m 2s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch
        Optional Tests javac unit
        git revision trunk / 6ae2a0d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 17s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 common tests 23m 33s Tests passed in hadoop-common.     39m 2s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch Optional Tests javac unit git revision trunk / 6ae2a0d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 8s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 common tests 22m 20s Tests passed in hadoop-common.
            37m 33s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch
        Optional Tests javac unit
        git revision trunk / a583a40
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6504/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6504/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6504/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 8s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 27s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 common tests 22m 20s Tests passed in hadoop-common.     37m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch Optional Tests javac unit git revision trunk / a583a40 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6504/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6504/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6504/console This message was automatically generated.
        Hide
        kiranmr Kiran Kumar M R added a comment -

        Reviewed and verified patch.
        case NULL: is not correct. It is void * pointer.
        VC++ compiler is allowing this somehow. This is usually not allowed in gcc.
        So changing this to NULL Termination '\0' is correct fix.

        Existing patch applies on both trunk and branch-2. No new patch needed.
        Compiled and tested this patch on windows. Its working fine.
        No new compilation warnings found.

        This can be committed.

        Show
        kiranmr Kiran Kumar M R added a comment - Reviewed and verified patch. case NULL: is not correct. It is void * pointer. VC++ compiler is allowing this somehow. This is usually not allowed in gcc. So changing this to NULL Termination '\0' is correct fix. Existing patch applies on both trunk and branch-2. No new patch needed. Compiled and tested this patch on windows. Its working fine. No new compilation warnings found. This can be committed.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the patch. Thanks for fixing this René Nyffenegger and thanks for the review and verification Kiran Kumar M R.

        I will commit it shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the patch. Thanks for fixing this René Nyffenegger and thanks for the review and verification Kiran Kumar M R . I will commit it shortly.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed for 2.8.0.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed for 2.8.0.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7778/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7778/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/src/main/winutils/chmod.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/)
        HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1)

        • hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/ ) HADOOP-10356 . Corrections in winutils/chmod.c (Contributed by René Nyffenegger) (arp: rev a0fae8dcae9e10cc7b751ed216017ded29177be1) hadoop-common-project/hadoop-common/src/main/winutils/chmod.c hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            René Nyffenegger René Nyffenegger
            Reporter:
            René Nyffenegger René Nyffenegger
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development