Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.4.0
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      LoadGenerator exit code is determined using the following logic

      int exitCode = init(args);
          if (exitCode != 0) {
            return exitCode;
          }
      

      At the end of the run we just return the exitCode. So essentially if you are arguments are correct you will always get 0 back.

      1. HADOOP-10328.000.patch
        7 kB
        Haohui Mai
      2. HADOOP-10328.001.patch
        7 kB
        Haohui Mai
      3. HADOOP-10328.002.patch
        7 kB
        Haohui Mai

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12627464/HADOOP-10328.000.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3545//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3545//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627464/HADOOP-10328.000.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3545//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3545//console This message is automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hi, Haohui. This patch looks good. Just 2 minor things:

          1. The br.close() and fr.close() could instead use IOUtils#cleanup to save a line of code and guard against IOException during closing.
          2. genFile could fail to close the file, because the close isn't in a finally block. This isn't directly related to your patch though. The code was always this way. If you prefer, we could queue up a separate issue to address that.
          Show
          cnauroth Chris Nauroth added a comment - Hi, Haohui. This patch looks good. Just 2 minor things: The br.close() and fr.close() could instead use IOUtils#cleanup to save a line of code and guard against IOException during closing. genFile could fail to close the file, because the close isn't in a finally block. This isn't directly related to your patch though. The code was always this way. If you prefer, we could queue up a separate issue to address that.
          Hide
          wheat9 Haohui Mai added a comment -

          Thanks Chris for the review. The v1 patch addresses the comments from Chris.

          Show
          wheat9 Haohui Mai added a comment - Thanks Chris for the review. The v1 patch addresses the comments from Chris.
          Hide
          cnauroth Chris Nauroth added a comment -

          genFile: I was thinking that the while loop with the write calls ought to go inside a try block, and then the close ought to go inside a finally block. Right now, an exception from one of the write calls would cause us to skip closing the file. (Sorry if my earlier comment was unclear about this.)

          Show
          cnauroth Chris Nauroth added a comment - genFile : I was thinking that the while loop with the write calls ought to go inside a try block, and then the close ought to go inside a finally block. Right now, an exception from one of the write calls would cause us to skip closing the file. (Sorry if my earlier comment was unclear about this.)
          Hide
          wheat9 Haohui Mai added a comment -

          The v2 patch address the comments.

          Show
          wheat9 Haohui Mai added a comment - The v2 patch address the comments.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the patch, pending Jenkins run on v2. Thank you for addressing the feedback.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the patch, pending Jenkins run on v2. Thank you for addressing the feedback.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12629894/HADOOP-10328.002.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3590//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3590//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629894/HADOOP-10328.002.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3590//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3590//console This message is automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          I committed this to trunk, branch-2 and branch-2.4. Thanks again, Haohui.

          Show
          cnauroth Chris Nauroth added a comment - I committed this to trunk, branch-2 and branch-2.4. Thanks again, Haohui.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5197 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5197/)
          HADOOP-10328. loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5197 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5197/ ) HADOOP-10328 . loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #488 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/488/)
          HADOOP-10328. loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #488 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/488/ ) HADOOP-10328 . loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1680 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1680/)
          HADOOP-10328. loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1680 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1680/ ) HADOOP-10328 . loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1705 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1705/)
          HADOOP-10328. loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1705 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1705/ ) HADOOP-10328 . loadGenerator exit code is not reliable. Contributed by Haohui Mai. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570304 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/loadGenerator/LoadGenerator.java

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              arpitgupta Arpit Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development