Hadoop Common
  1. Hadoop Common
  2. HADOOP-10296

null check for requestContentLen is wrong in SwiftRestClient#buildException()

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.3.0
    • Fix Version/s: None
    • Component/s: None
    • Target Version/s:

      Description

              if (requestContentLen!=null) {
                errorText.append(" available ").append(availableContentRange.getValue());
              }
      

      The null check should be for availableContentRange

      1. HADOOP-10296.2.patch
        3 kB
        kanaka kumar avvaru
      2. HADOOP-10296.1.patch
        0.9 kB
        Rahul Palamuttam

        Issue Links

          Activity

          Hide
          Rahul Palamuttam added a comment -

          Replaced requestContentLen with availableContentRange

          Show
          Rahul Palamuttam added a comment - Replaced requestContentLen with availableContentRange
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668695/HADOOP-10296.1.patch
          against trunk revision 14e2639.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-openstack.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4724//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4724//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668695/HADOOP-10296.1.patch against trunk revision 14e2639. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-openstack. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4724//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4724//console This message is automatically generated.
          Hide
          Akira AJISAKA added a comment -

          Thanks Rahul Palamuttam for the patch. LGTM, +1 (non-binding).

          Show
          Akira AJISAKA added a comment - Thanks Rahul Palamuttam for the patch. LGTM, +1 (non-binding).
          Hide
          Rahul Palamuttam added a comment -

          Should this bug be resolved now?

          Show
          Rahul Palamuttam added a comment - Should this bug be resolved now?
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 30s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 20s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 tools/hadoop tests 0m 15s Tests passed in hadoop-openstack.
              35m 17s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12668695/HADOOP-10296.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e8d0ee5
          hadoop-openstack test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6446/artifact/patchprocess/testrun_hadoop-openstack.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6446/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6446/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 38s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 tools/hadoop tests 0m 15s Tests passed in hadoop-openstack.     35m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12668695/HADOOP-10296.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e8d0ee5 hadoop-openstack test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6446/artifact/patchprocess/testrun_hadoop-openstack.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6446/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6446/console This message was automatically generated.
          Hide
          kanaka kumar avvaru added a comment -

          Planning to re-base the patch on trunk latest code. Rahul Palamuttam , if you would like to continue work on this JIRA please feel free to assign back to you.

          Show
          kanaka kumar avvaru added a comment - Planning to re-base the patch on trunk latest code. Rahul Palamuttam , if you would like to continue work on this JIRA please feel free to assign back to you.
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 43s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 31s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 19s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 0m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 15s Tests passed in hadoop-openstack.
              35m 33s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12668695/HADOOP-10296.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 39077db
          hadoop-openstack test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6822/artifact/patchprocess/testrun_hadoop-openstack.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6822/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6822/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 15s Tests passed in hadoop-openstack.     35m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12668695/HADOOP-10296.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 39077db hadoop-openstack test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6822/artifact/patchprocess/testrun_hadoop-openstack.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6822/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6822/console This message was automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Moving bugs out of previously closed releases into the next minor release 2.8.0.

          Show
          Vinod Kumar Vavilapalli added a comment - Moving bugs out of previously closed releases into the next minor release 2.8.0.
          Hide
          kanaka kumar avvaru added a comment -

          Just updated patch with latest code base from trunk. Also cleared some unused code warnings from SwiftRestClient class.

          New test case is not be required for the trivial change.

          Show
          kanaka kumar avvaru added a comment - Just updated patch with latest code base from trunk. Also cleared some unused code warnings from SwiftRestClient class. New test case is not be required for the trivial change.
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 25s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 34s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 19s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 14s Tests passed in hadoop-openstack.
              36m 32s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12743243/HADOOP-10296.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 37d7395
          hadoop-openstack test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7134/artifact/patchprocess/testrun_hadoop-openstack.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7134/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7134/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 14s Tests passed in hadoop-openstack.     36m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743243/HADOOP-10296.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 37d7395 hadoop-openstack test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7134/artifact/patchprocess/testrun_hadoop-openstack.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7134/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7134/console This message was automatically generated.

            People

            • Assignee:
              kanaka kumar avvaru
              Reporter:
              Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:

                Development