[GUMP-38] Does NOT cope with circular dependencies

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Gump2-2.4
• Fix Version/s: Gump3-alpha-3
• Component/s: Python-based Gump
• Assignee: Unassigned
• Reporter: Adam R. B. Jack
• Created: 23/Mar/04 14:33
• Updated: 19/Apr/05 05:05
• Resolved: 19/Apr/05 05:05

Description

1) Circular includes in metadata(href links that circle) are not detected. Logic will spin until it crashes.

2) Circular dependencies (perhaps within project property based dependencies) are not detected. Logic will spin until it crashes.

(most recent call last):
File "gump/integrate.py", line 85, in ?
irun()
File "gump/integrate.py", line 56, in irun
workspace=WorkspaceLoader().load(ws, 0)
File "/data3/gump/gump-install/python/gump/model/loader.py", line 96,
in load
XMLServer.map, XMLTracker.map)
File "/data3/gump/gump-install/python/gump/model/workspace.py", line
384, in complete
project.complete(self)
File "/data3/gump/gump-install/python/gump/model/project.py", line
468, in complete
dependency.getProject().complete(workspace)
File "/data3/gump/gump-install/python/gump/model/project.py", line
468, in complete
dependency.getProject().complete(workspace)
File "/data3/gump/gump-install/python/gump/model/project.py", line

<< really big snip of identical errors >>

468, in complete
dependency.getProject().complete(workspace)
File "/data3/gump/gump-install/python/gump/model/project.py", line
461, in complete
if self.ant: self.ant.expand(self,workspace)
File "/data3/gump/gump-install/python/gump/model/ant.py", line 52, in
expand
self.expandProperties(project,workspace)
File "/data3/gump/gump-install/python/gump/model/ant.py", line 61, in
expandProperties
self.importProperty(property)
File "/data3/gump/gump-install/python/gump/model/property.py", line
164, in importProperty
self.addProperty(Property(xmlproperty,self))
File "/data3/gump/gump-install/python/gump/model/property.py", line
27, in _init_
NamedModelObject._init_(self,xml.getName(),xml,parent)
File "/data3/gump/gump-install/python/gump/model/object.py", line
138, in _init_
ModelObject._init_(self,xml,owner)
File "/data3/gump/gump-install/python/gump/model/object.py", line 40,
in _init_
FileHolder._init_(self)
File "/data3/gump/gump-install/python/gump/utils/file.py", line 154,
in _init_
self.filelist=FileList(self)
File "/data3/gump/gump-install/python/gump/utils/file.py", line 118,
in _init_
Ownable._init_(self,owner)
File "/data3/gump/gump-install/python/gump/utils/owner.py", line 27,
in _init_
self.setOwner(owner)
File "/data3/gump/gump-install/python/gump/utils/owner.py", line 33,
in setOwner
if self == owner:
RuntimeError: maximum recursion depth exceeded
Integration completed with exit code : 1
Failed to integrate, exited with [1], exiting...