Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-684

Insufficient Credentials Should Take Precedence over Invalid Credentials

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.2.0
    • Component/s: guacamole
    • Labels:
      None

      Description

      The implementation of several modules that support 2FA/MFA has resulted in some scenarios where "GuacamoleInsufficientCredentialsException" exceptions are override by "GuacamoleInvalidCredentialsException" exceptions. Due to the way the AuthenticationService class currently handles those exceptions, there is no precedence - the first exception thrown is the one that is returned. This behavior should be changed such that GuacamoleInsufficientCredentialsException takes precedence over GuacamoleInvalidCredentialsException so that modules requesting additional credentials are not overriden or failed by modules that completely fail authentication. This will resolve some issues with the order of stacked modules mattering for whether authentication fails or prompts for additional credentials.

        Attachments

          Activity

            People

            • Assignee:
              vnick Nick Couchman
              Reporter:
              vnick Nick Couchman
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: