[GUACAMOLE-518] Shift incorrectly sent for uppercase letters while Caps Lock is active

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: RDP

Environment

Remote operating System : Ubuntu 16.04.3 LTS 64-bit
Local Browser : Chrome Version 64.0.3282.186 (Official Build) (64-bit)
XRDP Version : 0.9.5
Guacamole-Server Version : Latest Code [ Last Commit ID : bc5b01d4d8ab0c3c89a08007316d33012261f6b3 - GUACAMOLE-448: Merge support for configuring the level of caching used by RDP. ]
Guacamole-Client Version : Latest Code [ Last Commit ID : 5db2e3cae75a658b33515112a39eb2f5f8eef4a8 - GUACAMOLE-161: Merge changes adding Caps Lock to the do-not-auto-repeat list. ]

• Assignee: Mike Jumper
• Reporter: Amarjeet Singh
• Created: 06/Mar/18 07:59
• Updated: 22/May/21 20:39
• Resolved: 24/Jun/20 17:18

Description

As reported in the user@ mailing list:

I have been writing in Libre Office Writer on Guacamole RDP . I clicked CAPS lock and started writing but the text was still in lowercase.

Guacamole-Server version : 0.9.14
Guacamole-Client version : 0.9.14
XRDP Version : 0.9.5
Remote O.S. : Ubuntu 16.04.3 LTS 64-bit

I have not done any modifications in the code.

If I reconnect the RDP session with CAPS lock on, then it starts printing uppercase but if I again click CAPS lock to set it to lowercase, it still prints the uppercase.

This is apparently due to the way Guacamole's RDP support handles uppercase letters and Caps Lock:

• The client side of Guacamole handles Caps Lock correctly, and forwards this key as a key event to the Guacamole server.
• The RDP support handles the key correctly, sending the corresponding scancode to the RDP server.
• The RDP support handles the Caps Lock state incorrectly, continuing to send Shift keypresses for uppercase letters despite Caps Lock being active.

The RDP support needs to be modified such that the behavior of keys within each keyboard layout when Caps Lock is enabled, various modifiers are active/inactive, etc. can be correctly modeled. The keymaps currently only provide for defining behavior based on modifiers.

Issue Links

• is duplicated by: GUACAMOLE-349 RDP keymap translation unnecessarily presses SHIFT_L when SHIFT_R is held
• is duplicated by: GUACAMOLE-1037 Caps Lock doesn't work via RDP (1.2 guacd)
• is duplicated by: GUACAMOLE-1051 Bloq Mayus not working with RDP
• is related to: GUACAMOLE-520 Japanese keyboard layout for RDP incorrect
• is related to: GUACAMOLE-859 Incorrect Caps Lock keysym sent to Windows via RDP
• is related to: GUACAMOLE-801 Capslock / Shift key passthrough is strange over dual RDP
• relates to: GUACAMOLE-469 Sending extra shift key to rdp connections
• links to: CAPS lock is not working in XRDP version 0.9.5 with Ubuntu 16.0.4 [ Guacamole RDP ]