[GUACAMOLE-429] RDP may join on invalid thread during disconnect

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 0.9.12-incubating
• Component/s: RDP
• Environment: GNU Linux x86_64
• Assignee: Unassigned
• Reporter: James He
• Created: 04/Nov/17 00:34
• Updated: 23/Jul/19 19:44
• Resolved: 23/Jul/19 19:44

Description

Open 100 RDP connections at the same time with the below python script on Windows.

import webbrowser
for i in range(100):
    webbrowser.open_new_tab('http://10.148.38.170:8080/guacamole-0.9.13-incubating/#/client/cmRwAGMAZGVmYXVsdA==')

Some connections disconnected and observed the below core dump of guacd.

Program terminated with signal SIGSEGV, Segmentation fault.
#0  pthread_join (threadid=0, thread_return=0x0) at pthread_join.c:47
47      pthread_join.c: No such file or directory.
(gdb) bt
#0  pthread_join (threadid=0, thread_return=0x0) at pthread_join.c:47
#1  0x00002aaaafb6826c in guac_rdp_client_free_handler (client=0x2aaad4007990) at client.c:96
#2  0x00002aaaaaf45815 in guac_client_free (client=0x2aaad4007990) at client.c:193
#3  0x0000000000404d72 in guacd_exec_proc (proc=0x2aaad4007970, protocol=0x2aaad400bda3 "rdp") at proc.c:191
#4  0x0000000000404f3e in guacd_create_proc (protocol=0x2aaad400bda3 "rdp") at proc.c:253
#5  0x0000000000403bb8 in guacd_route_connection (map=0x2aaaaaad7010, socket=0x2aaad4005890)
    at connection.c:299
#6  0x0000000000403dc0 in guacd_connection_thread (data=0xe12b10) at connection.c:394
#7  0x00002aaaab8521a4 in start_thread (arg=0x2aab0a023700) at pthread_create.c:309
#8  0x00002aaaabd5965d in clone () from /lib64/libc.so.6
(gdb) frame 1
#1  0x00002aaaafb6826c in guac_rdp_client_free_handler (client=0x2aaad4007990) at client.c:96
96          pthread_join(rdp_client->client_thread, NULL);
(gdb) p rdp_client->client_thread
$5 = 0