[GUACAMOLE-400] Connection segfaults when SSH private key fails to load

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.13-incubating
• Fix Version/s: 0.9.14
• Component/s: SSH
• Environment: x86_64 GNU/Linux
• Assignee: Unassigned
• Reporter: James He
• Created: 28/Sep/17 17:31
• Updated: 17/Dec/17 07:57
• Resolved: 29/Sep/17 19:17

Description

Steps:

1. Generate a RSA key pair with ssh-keygen on Linux. Set private key passphrase.
2. Configure the public key on a SSH server.
3. Configure a SSH connection with the private key for authentication. Intentionally set a wrong passphrase!!
4. Start the SSH connection from web portal.

Expected result:

Connecting to the SSH server fails due to the wrong passphrase.

Actual result:

The SSH connection closes with a segfault.

(gdb) bt
#0 0x00002aaaae365596 in guac_common_ssh_authenticate (common_session=0x2aaab851d080) at ssh.c:300
#1 0x00002aaaae365c2c in guac_common_ssh_create_session (client=0x2aaab000ac40, hostname=0xe16e20 "10.148.38.168", port=0xe17100 "4118", user=0x0) at ssh.c:520
#2 0x00002aaaae35e01c in ssh_client_thread (data=0x2aaab000ac40) at ssh.c:220
#3 0x00002aaaab8521a4 in start_thread (arg=0x2aaab5001700) at pthread_create.c:309
#4 0x00002aaaabd5965d in clone () from /lib64/libc.so.6