[GUACAMOLE-306] VNC may segfault during the connection process

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.9.13-incubating
• Component/s: VNC
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 19/May/17 21:02
• Updated: 31/May/17 04:24
• Resolved: 21/May/17 19:27

Description

Guacamole's VNC implementation assumes that the rfbClient object will be available at the time that keyboard or mouse events occur, but this is not guaranteed. That object will only be available once the VNC connection process has completed.

Thus, if keys are pressed (or the clipboard contents are sent) while the connection is not yet ready, the event handler tries to send an event to NULL, a segfault occurs, and the Guacamole connection closes.