Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.13-incubating
    • Component/s: VNC
    • Labels:
      None

      Description

      I was having trouble getting Guacamole to connect to ESX 6.5's VNC server. The issue is reported here - https://github.com/LibVNC/libvncserver/issues/141

      Using TightVNC, TigerVNC, UltraVNC, and Chicken of the VNC the connection worked fine - only Guacamole failed. After some Wireshark sleuthing I found that libvncserver's client by default sets the trueColour flag to TRUE (which is -1 which is 255), whereas all of the other clients listed above set this flag to 1. Although the spec is vague - it says non-zero is "true" - I would suggest setting this flag to 1 to maximize compatibility:

      void guac_vnc_set_pixel_format(rfbClient* client, int color_depth) {
          client->format.trueColour = 1;
      

        Issue Links

          Activity

          Hide
          mike.jumper Michael Jumper added a comment -

          Proposed workaround for upstream bug now merged to master.

          Hopefully this will be fixed upstream. Either way, I think we should begin looking into whether we should migrate away from libvncclient entirely. This issue isn't all that severe, but I'm not sure we're really benefiting from using libvncclient anymore. It may be better to simply implement VNC directly ourselves.

          Show
          mike.jumper Michael Jumper added a comment - Proposed workaround for upstream bug now merged to master. Hopefully this will be fixed upstream. Either way, I think we should begin looking into whether we should migrate away from libvncclient entirely. This issue isn't all that severe, but I'm not sure we're really benefiting from using libvncclient anymore. It may be better to simply implement VNC directly ourselves.
          Hide
          dborth@hatsize.com Daryl Borth added a comment -
          Show
          dborth@hatsize.com Daryl Borth added a comment - Created pull request: https://github.com/apache/incubator-guacamole-server/pull/83

            People

            • Assignee:
              mike.jumper Michael Jumper
              Reporter:
              dborth@hatsize.com Daryl Borth
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development