Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-229

Intervals when polling xmlhttprequests are not always cleared

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      Tunnel.js' mechanism to fall back to polling when onreadystate doesn't work won't clear the intervals in certain conditions. The commit 627271953d6eee6f49f4a385d8de62d6a0098be5 accidentally changed the functionality of some conditions, causing 2 of the 3 clearIntervals to never clear an existing interval. My suspicion is that, on stock guacamole, it won't actually be doing much (just figuring out the message is already done parsing), but it still fires every 30ms until the socket closes.

      Pull request: https://github.com/apache/incubator-guacamole-client/pull/126

        Attachments

          Activity

            People

            • Assignee:
              mjumper Mike Jumper
              Reporter:
              teschnei Tyler Schneider

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment