Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-1850

guac_common_cursor_dup() may segfault if cursor is being modified

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.5.4
    • None
    • None

    Description

      The guac_common_cursor structure is written assuming that all access will already be threadsafe (such as existing access guarded by the guac_common_display lock), but guac_common_cursor is occasionally used outside the scope of any related locks (such as when handling inbound cursors from an RDP server). This results in a segfault/abort if that usage happens to occur while a guac_common_cursor_dup() call is underway.

      guac_common_cursor probably needs its own locks, similar to the issue with guac_common_clipboard that was addressed with: https://github.com/apache/guacamole-server/pull/178

      Attachments

        Activity

          People

            Unassigned Unassigned
            mjumper Mike Jumper
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: