[GUACAMOLE-1718] Configure script fails when "--with-libavformat=no" is specified

• Type: Bug
• Status: In Progress
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.5.3
• Component/s: guacamole-server
• Assignee: Mike Jumper
• Reporter: Libor Svehlak
• Created: 23/Nov/22 15:12
• Updated: 19/Sep/23 17:03

Description

Steps to reproduce:

tar -xzf guacamole-server-1.5.3.tar.gz
cd guacamole-server-1.5.3
./configure --with-libavformat=no

Output:

....
checking for ssize_t... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for AVCODEC... no
./configure: line 15051: .: filename argument required
.: usage: . filename [arguments] 

Reason: There seems to be a typo in configure.ac file on the line 251 (line 15051 in generated configure script provided in the source package). There is specified []. instead of the correct [],:

#
# libavformat
#

have_libavformat=disabled
AC_ARG_WITH([libavformat],
	    [AS_HELP_STRING([--with-libavformat],
	                    [use libavformat when encoding video @<:@default=check@:>@])],
            [].
            [with_libavformat=check])
if test "x$with_libavformat" != "xno"
then
    have_libavformat=yes
    PKG_CHECK_MODULES([AVFORMAT], [libavformat],, [have_libavformat=no]);
fi

Side question / suggestion for enhancement: Isn't there a build & test infrastructure to test that at least specification of switches (combination of switches) are not causing build errors? Due to large test space (amount of switches and their values) it would be most probably impossible to test all combinations nevertheless at least a basic check (e.g. nothing provided, all switches provided with "no" value, etc.) can help to avoid such errors in the future.