Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-169

Use namespace for common utility headers

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 0.9.12-incubating
    • Component/s: guacamole-server
    • Labels:
      None

      Description

      The headers within src/common/ currently rely instead on cumbersome naming like guac_rect.h to differentiate themselves from headers which might be present in the parts of guacamole-server which use that utility library.

      These headers should instead use a namespaced directory, similar to the way libguac headers are found within the "guacamole" directory. Code would thus end up including these headers like:

      #include "common/rect.h"
      

      rather than:

      #include "guac_rect.h"
      

        Issue Links

          Activity

          Hide
          mike.jumper Michael Jumper added a comment -

          We should do the same for src/common-ssh/ and src/terminal/. They're the only utility libraries still relying on the old naming.

          Show
          mike.jumper Michael Jumper added a comment - We should do the same for src/common-ssh/ and src/terminal/ . They're the only utility libraries still relying on the old naming.

            People

            • Assignee:
              mike.jumper Michael Jumper
              Reporter:
              mike.jumper Michael Jumper
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development