[GUACAMOLE-1416] An improper locking bug (e.g., resource leak) due to unreleased lock

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.5.0
• Component/s: guacamole, guacamole-server
• External issue URL: https://github.com/apache/guacamole-server/blob/b2ae2fdf003a6854ac42877ce0fce8e88ceb038a/src/protocols/ssh/ssh.c#L424-L453
• Assignee: Unassigned
• Reporter: Ryan Cai
• Created: 05/Sep/21 06:10
• Updated: 13/Feb/23 23:41
• Resolved: 13/Feb/23 23:41

Description

In the below codes, the lock pthread_mutex_lock(&(ssh_client->term_channel_lock)) , the resource, can not be correctly released if libssh2_keepalive_send(ssh_client->session->session, &timeout) > 0.

 
Locations:
https://github.com/apache/guacamole-server/blob/b2ae2fdf003a6854ac42877ce0fce8e88ceb038a/src/protocols/ssh/ssh.c#L424-L453