[GUACAMOLE-1276] RDP file uploads may (still) be truncated to 32 bits

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.3.0
• Fix Version/s: 1.4.0
• Component/s: RDP
• Assignee: Nick Couchman
• Reporter: wuxiaobai
• Created: 02/Feb/21 08:07
• Updated: 15/May/21 00:18
• Resolved: 15/May/21 00:18

Description

From GUACAMOLE-764:

While file sizes are now properly-represented with 64-bit integers (see GUACAMOLE-268), the offset of each read/write is still a simple int. This will limit the location of each read or write to a 32-bit addressable space, thus effectively limiting the size of files transferred to 4 GB: ...

This was correctly addressed with guacamole-server PR #223, but those changes were inadvertently undone during conflict resolution of GUACAMOLE-249, and that offset is back to being an int:

https://github.com/mike-jumper/guacamole-server/blob/53f981f864475763f64d608ca1dfea7c7e094472/src/protocols/rdp/upload.h#L36-L40

Issue Links

• is caused by: GUACAMOLE-249 Update RDP plugin support to 2.0.0 releases
• relates to: GUACAMOLE-764 RDPDR file read/write may be truncated to 32 bits