Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-1276

RDP file uploads may (still) be truncated to 32 bits

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.4.0
    • Component/s: RDP
    • Labels:
      None

      Description

      From GUACAMOLE-764:

      While file sizes are now properly-represented with 64-bit integers (see GUACAMOLE-268), the offset of each read/write is still a simple int. This will limit the location of each read or write to a 32-bit addressable space, thus effectively limiting the size of files transferred to 4 GB: ...

      This was correctly addressed with guacamole-server PR #223, but those changes were inadvertently undone during conflict resolution of GUACAMOLE-249, and that offset is back to being an int:

      https://github.com/mike-jumper/guacamole-server/blob/53f981f864475763f64d608ca1dfea7c7e094472/src/protocols/rdp/upload.h#L36-L40

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vnick Nick Couchman
                Reporter:
                qq296015668 wuxiaobai
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: