[GUACAMOLE-1227] Build fails against libvncclient 0.9.7

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.3.0
• Fix Version/s: 1.4.0
• Component/s: VNC
• Assignee: Mike Jumper
• Reporter: Mike Jumper
• Created: 03/Dec/20 06:52
• Updated: 03/Dec/20 19:38
• Resolved: 03/Dec/20 19:38

Description

When building guacamole-server against libvncclient 0.9.7 (the version of libvncclient provided by CentOS 6 via its libvncserver package), the build fails with the following error:

...
  CC     libguac_client_vnc_la-argv.lo
  CC     libguac_client_vnc_la-auth.lo
In file included from auth.c:23:
auth.h:57: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
auth.c:66: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
make[2]: *** [libguac_client_vnc_la-auth.lo] Error 1

This is because the GetCredential callback and rfbCredential type do not exist in that version of libvncclient. If that version is to continue to be supported, the relevant part of the build should be made conditional.

Issue Links

• is caused by: GUACAMOLE-514 Implement additional authentication methods for VNC