[GROOVY-9852] Result is already complete (IllegalStateException)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.5
• Fix Version/s: 4.0.0-alpha-3
• Labels: breaking breaking_change
• Environment: Windows 10 ; OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_272-b10)
• Flags: Important
• Assignee: Eric Milles
• Reporter: André Filipe Aloise
• Created: 07/Dec/20 17:58
• Updated: 15/Jan/24 14:08
• Resolved: 13/Dec/20 06:06

Description

Steps:

1 - Consider this reproducer https://github.com/ptomaszek/vertx-groovy

2 - Edit build.gradle and change vertxVersion to '4.0.0.Beta1' (uses Groovy 3.0.3)

3 - Edit org.example.MainGroovy and replace the code of main method with the following:

Promise p = Promise.promise()
p.future().onSuccess { println it }
p.complete("Done with Groovy!!!")

The code runs fine.

But, if in Step 2 the vertxVersion in build.gradle is changed to '4.0.0.Beta2' (uses Groovy 3.0.5), the code from Step 3 will fail with an IllegalStateException. 

Exception in thread "main" java.lang.IllegalStateException: Result is already complete
 at io.vertx.core.Promise.complete(Promise.java:67)
 at io.vertx.core.Promise$complete$1.call(Unknown Source)
 at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
 at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
 at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139)
 at org.example.MainGroovy.main(MainGroovy.groovy:17)

If you use @CompileStatic on main method with Step 3, with Beta2, it works fine. The @CompileStatic is not necessary to run well with Vert.x '4.0.0.Beta1'. A Java class with similar code will work using any version of Vert.x (Beta1, Beta2, Beta3, CR1....), so doesn't looks like a Java or Vertx issue.

Issue Links

• is related to: GROOVY-6189 basic SAM conversion
• is related to: GROOVY-5114 String[] to Set coercion seems broken in some cases
• relates to: GROOVY-11010 Ambiguous method reference when expecting a SAM type
• relates to: GROOVY-10714 STC: Callable, Runnable, Serializable overload preference for functional argument (closure, lambda, etc.)
• relates to: GROOVY-10963 AIOOBE with Java lambda syntax
• relates to: GROOVY-11121 unexpected error when having overloaded methods, one of which receiving an Iterable