[GROOVY-9777] Stub missing cast, depending on constructor order

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.6
• Fix Version/s: 3.0.8, 4.0.0-alpha-3, 2.5.21
• Component/s: Stub generator / Joint compiler
• Assignee: Eric Milles
• Reporter: Keegan Witt
• Created: 11/Oct/20 19:40
• Updated: 18/Jan/23 00:02
• Resolved: 02/Mar/21 15:11

Description

 

package org.apache.groovy.tests
class Parent {
    Parent(Object context) {
        this(context.class.name)
    }
    Parent(Class<?> context) {
        this(context.name)
    }
    Parent(String context) {}
}
class Child extends Parent {
    Child() {
        super(Child.class.name)
    }
}

Generates this stub for Child, missing the cast in the constructor

package org.apache.groovy.tests;
import java.lang.*;
import java.util.*;
import java.io.*;
import java.net.*;
import groovy.lang.*;
import groovy.util.*;

public class Child
  extends org.apache.groovy.tests.Parent {
;
public Child
() {
super (null);
}
@groovy.transform.Generated() @groovy.transform.Internal() @java.beans.Transient() public  groovy.lang.MetaClass getMetaClass() { return (groovy.lang.MetaClass)null;}
@groovy.transform.Generated() @groovy.transform.Internal() public  void setMetaClass(groovy.lang.MetaClass mc) { }
}

Which causes the Java compilation to fail

Child.java:[14,1] reference to Parent is ambiguous
   both constructor Parent(java.lang.Class<?>) in org.apache.groovy.tests.Parent and constructor Parent(java.lang.String) in org.apache.groovy.tests.Parent match

 

But 

package org.apache.groovy.tests
class Parent {
    Parent(Class<?> context) {
        this(context.name)
    }
    Parent(String context) {}
    Parent(Object context) {
        this(context.class.name)
    }
}
class Child extends Parent {
    Child() {
        super(Child.class.name)
    }
}

Generates this stub for Child, with the cast in it

package org.apache.groovy.tests;
import java.lang.*;
import java.util.*;
import java.io.*;
import java.net.*;
import groovy.lang.*;
import groovy.util.*;

public class Child
  extends org.apache.groovy.tests.Parent {
;
public Child
() {
super ((java.lang.Class)null);
}
@groovy.transform.Generated() @groovy.transform.Internal() @java.beans.Transient() public  groovy.lang.MetaClass getMetaClass() { return (groovy.lang.MetaClass)null;}
@groovy.transform.Generated() @groovy.transform.Internal() public  void setMetaClass(groovy.lang.MetaClass mc) { }
}