[GROOVY-9699] @CompileStatic does not use bridge methods for keyed map access

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1, 2.5.14, 3.0.6
• Component/s: Static compilation
• Assignee: Eric Milles
• Reporter: Leonard Brünings
• Created: 20/Aug/20 16:18
• Updated: 11/Nov/20 02:00
• Resolved: 15/Sep/20 03:35

Description

Extracted from GROOVY-9695:

import java.util.regex.Pattern
import org.junit.Test
import groovy.transform.CompileStatic

class Example {

    @Test
    void testBaseListClass() {
        new Base().checkList()
    }

    @Test
    void testChildListClass() {
        new Child().checkList()
    }

    @Test
    void testBaseMapClass() {
        new Base().checkMap()
    }

    @Test
    void testChildMapClass() {
        new Child().checkMap()
    }

}

@CompileStatic
class Base {
    private static final Pattern PATTERNS = ~/.*Test/

    def checkList() {
        List failures = []

        def closure = {
            failures << PATTERNS.pattern()
        }
        closure()
    }

    def checkMap() {
        Map failures = [:]

        def closure = {
            failures[PATTERNS.pattern()] = 1
        }
        closure()
    }
}

class Child extends Base {

}
 

For the list it works fine (Procyon Decompiler)

    public Object doCall(final Object it) {
        return DefaultGroovyMethods.leftShift((List<String>)ScriptBytecodeAdapter.castToType(this.failures.get(), List.class), Base.pfaccess$0((Base)null).pattern());
    }
 

For the map it doesn't use the bridge method (Procyon Decompiler)

    public Object doCall(final Object it) {
        final int n = 1;
        DefaultGroovyMethods.putAt((Map<String, Integer>)ScriptBytecodeAdapter.castToType(this.failures.get(), Map.class), ((Pattern)this.getProperty("PATTERNS")).pattern(), n);
        return n;
    }
 

Issue Links

• relates to: GROOVY-9695 Regression for accessing private static constants in closures from Parent Classes