[GROOVY-9233] Add @ClosureParams to closure input parameter of Sql.withBatch(...)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.8
• Fix Version/s: 2.5.9, 3.0.0-rc-1
• Component/s: SQL processing
• Assignee: Eric Milles
• Reporter: Mauro Molinari
• Created: 22/Aug/19 14:15
• Updated: 24/Nov/19 02:44
• Resolved: 09/Sep/19 23:59

Description

Similar to GROOVY-9229.

The overloadings of groovy.sql.Sql.withBatch(...) do not declare the closure input parameter type. It's not so straightforward to find out what is the type of the parameter the closure is expected to receive, you have to read the Javadoc carefully or look at the implementation. The documentation at http://groovy-lang.org/databases.html talks about statements and prepared statements, but actually the injected parameter is of type BatchingStatementWrapper or BatchingPreparedStatementWrapper, depending on the overloading.

It's especially annoying when you use static compilation.