[GROOVY-9229] Add @ClosureParams to closure input parameter of Sql.withInstance(...)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.8
• Fix Version/s: 2.5.9, 3.0.0-rc-1
• Component/s: SQL processing
• Assignee: Eric Milles
• Reporter: Mauro Molinari
• Created: 19/Aug/19 09:55
• Updated: 24/Nov/19 02:45
• Resolved: 09/Sep/19 23:59

Description

The various overloadings of Sql.withInstance do not specify the input parameter type of the closure, which is groovy.sql.Sql. Hence, if you want even minimal help from the IDE you won't get anything, unless you declare the input type in your closure declaration:

Example:

Sql.withInstance(url, user, pass) { sql ->
  sql.connec| <= invoke code assist here
}

The IDE does not give any help and, if the surrounding code is type checked, you'll even get a compilation error.

Required workaround:

Sql.withInstance(url, user, pass) { Sql sql ->
  sql.connec| <= invoke code assist here
}

Issue Links

• links to: GitHub Pull Request #1003